Predict volume #280
Open
Predict volume #280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ziw-liu, @tayllatheodoro is actively working on this branch to get a prototype ready for Friday. Can you please keep an eye on it and provide quick feedback where needed? Thanks! |
edyoshikun
reviewed
Aug 28, 2025
edyoshikun
reviewed
Aug 28, 2025
viscy/api/inference.py
Outdated
| model_class = getattr(importlib.import_module(module_path), class_name) | ||
|
|
||
| # Instantiate model | ||
| model = model_class(**init_args).to(x.device).eval() |
There was a problem hiding this comment.
move it to the model to device and move the tensors to the device.
viscy/translation/engine.py
Outdated
| weights = x.new_zeros((1, 1, Z, 1, 1)) | ||
|
|
||
| pad = getattr(self, "_predict_pad", None) | ||
| if pad is None: |
There was a problem hiding this comment.
Im not sure if this is needed?
ziw-liu
reviewed
Aug 28, 2025
ziw-liu
reviewed
Aug 28, 2025
ziw-liu
reviewed
Aug 28, 2025
ziw-liu
reviewed
Aug 28, 2025
ziw-liu
reviewed
Aug 28, 2025
ziw-liu
reviewed
Aug 28, 2025
ziw-liu
reviewed
Aug 28, 2025
ziw-liu
reviewed
Aug 29, 2025
ziw-liu
reviewed
Aug 29, 2025
ziw-liu
reviewed
Aug 29, 2025
ziw-liu
reviewed
Aug 29, 2025
ziw-liu
reviewed
Aug 29, 2025
ziw-liu
reviewed
Aug 29, 2025
ziw-liu
reviewed
Aug 29, 2025
ziw-liu
reviewed
Aug 29, 2025
ziw-liu
reviewed
Aug 29, 2025
ziw-liu
requested changes
Aug 29, 2025
Co-authored-by: Ziwen Liu <[email protected]>
Co-authored-by: Ziwen Liu <[email protected]>
Co-authored-by: Ziwen Liu <[email protected]>
Co-authored-by: Ziwen Liu <[email protected]>
Co-authored-by: Ziwen Liu <[email protected]>
Co-authored-by: Ziwen Liu <[email protected]>
Co-authored-by: Ziwen Liu <[email protected]>
ziw-liu
reviewed
Sep 5, 2025
Comment on lines
+566
to
+569
| if not hasattr(self, "_predict_pad"): | ||
| raise RuntimeError( | ||
| "Missing _predict_pad; make sure to call `on_predict_start()` before inference." | ||
| ) |
There was a problem hiding this comment.
This attribute is assigned in __init__, and I don't see a on_predict_start hook implemented for this class.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #279
TODO: