Merge pull request #66 from meilisearch/fix-writer-clear

Add a test to check if Writer::clear works

Author: irevoire

src/tests/writer.rs

@@ -1,9 +1,39 @@
+use heed::EnvOpenOptions;
 use rand::seq::SliceRandom;
 use rand::Rng;
 
 use super::{create_database, rng};
-use crate::distance::Euclidean;
-use crate::Writer;
+use crate::distance::{DotProduct, Euclidean};
+use crate::{Database, Reader, Writer};
+
+#[test]
+fn clear_small_database() {
+    let _ = rayon::ThreadPoolBuilder::new().num_threads(1).build_global();
+
+    let dir = tempfile::tempdir().unwrap();
+    let env = EnvOpenOptions::new().map_size(200 * 1024 * 1024).open(dir.path()).unwrap();
+
+    let mut wtxn = env.write_txn().unwrap();
+    let database: Database<DotProduct> = env.create_database(&mut wtxn, None).unwrap();
+
+    let zero_writer = Writer::new(database, 0, 3);
+    zero_writer.add_item(&mut wtxn, 0, &[0.0, 1.0, 2.0]).unwrap();
+    zero_writer.clear(&mut wtxn).unwrap();
+    zero_writer.build(&mut wtxn, &mut rng(), None).unwrap();
+
+    let one_writer = Writer::new(database, 1, 3);
+    one_writer.add_item(&mut wtxn, 0, &[1.0, 2.0, 3.0]).unwrap();
+    one_writer.build(&mut wtxn, &mut rng(), None).unwrap();
+    wtxn.commit().unwrap();
+
+    let mut wtxn = env.write_txn().unwrap();
+    let zero_writer = Writer::new(database, 0, 3);
+    zero_writer.clear(&mut wtxn).unwrap();
+
+    let one_reader = Reader::open(&wtxn, 1, database).unwrap();
+    assert_eq!(one_reader.item_vector(&wtxn, 0).unwrap().unwrap(), vec![1.0, 2.0, 3.0]);
+    wtxn.commit().unwrap();
+}
 
 #[test]
 fn use_u32_max_minus_one_for_a_vec() {

src/writer.rs

@@ -205,7 +205,7 @@ impl<D: Distance> Writer<D> {
             .database
             .remap_key_type::<PrefixCodec>()
             .prefix_iter_mut(wtxn, &Prefix::all(self.index))?
-            .remap_key_type::<DecodeIgnore>();
+            .remap_types::<DecodeIgnore, DecodeIgnore>();
 
         while let Some((_id, _node)) = cursor.next().transpose()? {
             // safety: we don't have any reference to the database