Make index swap test more permissive

[Strift]

Fix Meilisearch 1.18 tests run

Summary by CodeRabbit

• Tests
  • Strengthened validation for swap-related responses by replacing broad deep-equality checks with targeted, element-wise assertions.
  • Added explicit length verification to ensure the expected number of items is returned.
  • Reduced brittleness by focusing on key fields rather than entire structures, making tests more resilient to non-essential changes.
  • Improved failure diagnostics to make issues easier to identify and resolve during test runs.
  • No user-facing behavior changes.

[coderabbitai]

Walkthrough

Reworked a test in swaps_test.dart to validate the swaps response by casting to a List, asserting length, and checking specific inner map values via indexed access instead of a single deep-structure equality assertion.

Changes

Cohort / File(s)	Summary
Test validation updates test/swaps_test.dart	Replaced deep equality check with element-wise assertions; cast details['swaps'] to List, added length check (2), and verified indexes for first and second elements against expected books and movies maps.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

In the meadow of tests I hop with cheer,
No giant equals to wrangle here—
Two swaps counted, neat and clear,
Books, then movies, checked ear to ear.
With list in paw, I validate tight,
Carrot-approved: the assertions are right! 🥕✨

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

✨ Finishing Touches

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch chore/fix-tests-after-v1.18

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

test/swaps_test.dart (1)

34-37: Assertions still rely on list order; make them order-agnostic (and robust to pair order).

Good move away from deep structural equality. However, indexing into responseSwaps assumes the backend preserves the order of swaps, which may change across versions or implementations. Also, some backends may reorder the two indexes within each pair. Prefer presence-based, order-agnostic assertions.

Apply this diff to avoid order assumptions and slightly strengthen typing:

-      var responseSwaps = response.details!['swaps'] as List;
-      expect(responseSwaps, hasLength(2));
-      expect(responseSwaps[0]['indexes'], books);
-      expect(responseSwaps[1]['indexes'], movies);
+      final responseSwaps =
+          (response.details!['swaps'] as List).cast<Map<String, dynamic>>();
+      expect(responseSwaps, hasLength(2));
+      expect(
+        responseSwaps,
+        anyElement(containsPair('indexes', unorderedEquals(books))),
+      );
+      expect(
+        responseSwaps,
+        anyElement(containsPair('indexes', unorderedEquals(movies))),
+      );

This:

• Doesn’t depend on the order of swaps returned by the server.
• Doesn’t depend on the order of the two indexes within each swap.
• Gives better IDE/type help on responseSwaps.

If the API guarantees both orders are stable, feel free to keep the simpler assertions—but given the PR objective to make the test more permissive, this version is safer.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between c2a706c and c1ad39c.

📒 Files selected for processing (1)

• test/swaps_test.dart (1 hunks)

[curquiza]

bors merge

[meili-bors]

Build succeeded:

• integration-tests (dart latest)
• pana
• linter-check