Added skipCreation param to document methods#473
Added skipCreation param to document methods#473M4dhav wants to merge 1 commit intomeilisearch:mainfrom
Conversation
📝 WalkthroughWalkthroughThis PR implements support for the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
lib/src/index.dart (1)
123-133: Refresh public method docs to includeskipCreation.Current doc comments mention optional
primaryKeybut omit the newly added option, which can confuse SDK users.✍️ Proposed doc update
- /// Add a list of documents by given [documents] and optional [primaryKey] parameter. + /// Add a list of documents by given [documents] and optional [primaryKey] + /// and [skipCreation] parameters. ... - /// Add a list of documents or update them if they already exist by given [documents] and optional [primaryKey] parameter. + /// Add a list of documents or update them if they already exist by given + /// [documents] and optional [primaryKey] and [skipCreation] parameters.Also applies to: 288-296
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@lib/src/index.dart` around lines 123 - 133, The public doc comments for addDocuments (templates meili.add_docs and meili.index_upsert) are missing the newly added skipCreation parameter; update the method documentation to describe the skipCreation bool option (its purpose, default behavior, and effect when true/false) alongside the existing primaryKey description, and mirror the same documentation update for the other overloaded/related method comments referenced in the file (the second addDocuments/doc block later in the file) so users see skipCreation documented consistently.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@lib/src/index.dart`:
- Around line 123-133: The public doc comments for addDocuments (templates
meili.add_docs and meili.index_upsert) are missing the newly added skipCreation
parameter; update the method documentation to describe the skipCreation bool
option (its purpose, default behavior, and effect when true/false) alongside the
existing primaryKey description, and mirror the same documentation update for
the other overloaded/related method comments referenced in the file (the second
addDocuments/doc block later in the file) so users see skipCreation documented
consistently.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 31dbb927-ce61-452e-8a5d-3a8710a01627
📒 Files selected for processing (3)
.code-samples.meilisearch.yamllib/src/index.darttest/code_samples.dart
|
Checking why tests are failing |
|
Hey @curquiza , looks like the tests failure is unrelated to my changes, as this test has been failing on all recent PRs ( Check https://github.com/meilisearch/meilisearch-dart/actions/workflows/tests.yml ). |
Pull Request
##ISSUE Number
Fixes #459
What does this PR do?
PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!
Summary by CodeRabbit
Release Notes
New Features
skipCreationparameter to document add and update operations, enabling control over automatic collection creation behavior.Documentation