Skip to content

Conversation

@Barabasbalazs
Copy link
Contributor

Pull Request

Related issue

Fixes #770

What does this PR do?

  • Implements support for the localizedAttributes setting, locales search parameter and updates the tests accordingly.

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@curquiza
Copy link
Member

curquiza commented Nov 6, 2024

@Barabasbalazs thanks for your PR

Can you fix the tests and the linter before I review?

@Barabasbalazs
Copy link
Contributor Author

@curquiza fixed the linting issues

@curquiza
Copy link
Member

curquiza commented Nov 6, 2024

@Barabasbalazs tests look good ✅

Can you fix the git conflicts, since your other PR has been merged?

@Barabasbalazs
Copy link
Contributor Author

@curquiza should be good now

@curquiza curquiza self-requested a review November 7, 2024 13:27
@curquiza curquiza added the enhancement New feature or request label Nov 27, 2024
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@meili-bors
Copy link
Contributor

meili-bors bot commented Nov 27, 2024

Build succeeded:

  • integration-and-unit-tests
  • linter

@meili-bors meili-bors bot merged commit e17aa89 into meilisearch:main Nov 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[v1.10.0] Language settings & search parameter

2 participants