Skip to content

Make return type of facet-search to concrete type results. #806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
junghoon-vans wants to merge 2 commits into from
Closed

Make return type of facet-search to concrete type results. #806

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d3944db
Make return type of facet-search to concrete type results.
junghoon-vans Jan 22, 2025
f49e74d
Fix linter error
junghoon-vans Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/main/java/com/meilisearch/sdk/FacetSearch.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

import com.meilisearch.sdk.exceptions.MeilisearchException;
import com.meilisearch.sdk.model.FacetSearchResult;
import com.meilisearch.sdk.model.FacetSearchable;

/**
* Class used for performing facet searching on Meilisearch indexes
Expand Down Expand Up @@ -37,7 +36,7 @@ String rawSearch(String uid, FacetSearchRequest fsr) throws MeilisearchException
return httpClient.post(requestQuery, fsr.toString(), String.class);
}

FacetSearchable facetSearch(String uid, FacetSearchRequest fsr) throws MeilisearchException {
FacetSearchResult facetSearch(String uid, FacetSearchRequest fsr) throws MeilisearchException {
return httpClient.jsonHandler.decode(rawSearch(uid, fsr), FacetSearchResult.class);
}
}
2 changes: 1 addition & 1 deletion src/main/java/com/meilisearch/sdk/Index.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -447,7 +447,7 @@ public Searchable search(SearchRequest searchRequest) throws MeilisearchExceptio
* @see Index#updateFilterableAttributesSettings(String[]) updateFilterableAttributesSettings
* @since 1.3
*/
public FacetSearchable facetSearch(FacetSearchRequest facetSearchRequest)
public FacetSearchResult facetSearch(FacetSearchRequest facetSearchRequest)
throws MeilisearchException {
return this.facetSearch.facetSearch(this.uid, facetSearchRequest);
}
Expand Down
Loading