Skip to content

Conversation

@svavassori
Copy link
Contributor

Pull Request

Related issue

Fixes #834

What does this PR do?

  • It adds empty string check before adding the Authorization header, so to make it consistent with the default apiKey value set by the host-only Config constructor

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@curquiza curquiza requested a review from Copilot April 4, 2025 13:42
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@svavassori
Copy link
Contributor Author

@curquiza any news or doubts about this PR?

Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@meili-bors
Copy link
Contributor

meili-bors bot commented Apr 22, 2025

Build succeeded:

@meili-bors meili-bors bot merged commit da852f7 into meilisearch:main Apr 22, 2025
3 checks passed
@curquiza curquiza added the bug Something isn't working label Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CustomOkHttpClient uses an empty API key from Config to set Authotization Header

2 participants