Skip to content

Conversation

@brunoocasali
Copy link
Member

@brunoocasali brunoocasali commented May 30, 2025

CC: https://central.sonatype.org/news/20250326_ossrh_sunset/

Pull Request

Related issue

Fixes #198

What does this PR do?

  • Fix the CI by migrating to the new Maven Central
  • Update the publishing CI to use Java 17.
  • Update gradle to use v8.14

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

Summary by CodeRabbit

  • Chores
    • Updated publishing workflow to use the new Maven Central (Sonatype) portal and modernized authentication and signing methods.
    • Upgraded Gradle wrapper to version 8.14.1.
    • Removed outdated publishing workflow and configuration for OSSRH.
  • Documentation
    • Revised contributor instructions for publishing, updating environment variable names, key export steps, and URLs to match the new Maven Central process.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented May 30, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

The changes update the project's Maven Central publishing workflow by deleting the old OSSRH GitHub Actions workflow and introducing a new workflow compatible with the latest Sonatype Central requirements. Supporting documentation, Gradle build scripts, and environment variable usage were modernized accordingly. The Gradle wrapper was also upgraded to version 8.14.1.

Changes

File(s) Change Summary
.github/workflows/ossrh-publish.yml Removed deprecated OSSRH publishing workflow.
.github/workflows/publish.yml Added new Maven Central publishing workflow using updated environment variables and JDK version.
CONTRIBUTING.md Updated publishing instructions, environment variables, and URLs to reflect new Sonatype Central process.
build.gradle Updated publishing/signing configuration for new Sonatype Central API, changed env vars, removed old blocks.
gradle/wrapper/gradle-wrapper.properties Upgraded Gradle wrapper from 8.1 to 8.14.1.

Sequence Diagram(s)

sequenceDiagram
    participant Developer
    participant GitHub Actions
    participant Gradle
    participant Sonatype Central

    Developer->>GitHub Actions: Push tag v*
    GitHub Actions->>GitHub Actions: Checkout code
    GitHub Actions->>GitHub Actions: Set up JDK 17 (Temurin)
    GitHub Actions->>Gradle: Run publish command with env vars
    Gradle->>Sonatype Central: Publish artifacts (using new API and credentials)
    Sonatype Central-->>Gradle: Acknowledge publication
    Gradle-->>GitHub Actions: Complete job
Loading

Assessment against linked issues

Objective (Issue #) Addressed Explanation
Remove deprecated option (#198)

Poem

A rabbit hops with nimble feet,
As workflows change and docs repeat.
Old scripts retire, new ones gleam,
Gradle jumps to fourteen—what a team!
Maven Central, here we go,
With modern keys and tokens in tow.
🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6381b7b and 2364eb5.

📒 Files selected for processing (5)
  • .github/workflows/ossrh-publish.yml (0 hunks)
  • .github/workflows/publish.yml (1 hunks)
  • CONTRIBUTING.md (2 hunks)
  • build.gradle (2 hunks)
  • gradle/wrapper/gradle-wrapper.properties (1 hunks)

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@brunoocasali brunoocasali added enhancement New feature or request maintenance Anything related to maintenance (CI, tests, refactoring...) labels May 30, 2025
@brunoocasali
Copy link
Member Author

This PR has been released as this tag: https://github.com/meilisearch/meilisearch-java/releases/tag/v0.14.5 to ensure its working.

@brunoocasali brunoocasali merged commit 09be090 into main May 30, 2025
2 of 3 checks passed
@brunoocasali brunoocasali deleted the migrate-relase-process branch May 30, 2025 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request maintenance Anything related to maintenance (CI, tests, refactoring...)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants