Fix failing tests in Meilisearch 1.16 CI #875

Strift · 2025-07-30T07:49:37Z

Pull Request

Why

Fix failing tests in Meilisearch 1.16 CI: https://github.com/meilisearch/meilisearch/actions/runs/16573762878/job/46872729353

What does this PR do?

Use UTC format for expiredAt date
Remove checks for the number of API keys

Thank you so much for contributing to Meilisearch!

Summary by CodeRabbit

Bug Fixes
- Improved date formatting to ensure consistent and thread-safe handling of UTC time zone dates.

coderabbitai · 2025-07-30T07:49:46Z

Walkthrough

The static DateFormat instance in GsonKeyTypeAdapter was replaced by a ThreadLocal<SimpleDateFormat> to ensure thread safety and explicitly set to UTC time zone. Additionally, test assertions in KeysTest were modified by removing checks on the exact number of keys, while retaining other validation logic.

Changes

Cohort / File(s)	Change Summary
Thread-safe Date Format Initialization `src/main/java/com/meilisearch/sdk/json/GsonKeyTypeAdapter.java`	Replaced static `DateFormat` with `ThreadLocal<SimpleDateFormat>` initialized with UTC time zone for thread safety.
Test Assertion Updates `src/test/java/com/meilisearch/integration/KeysTest.java`	Removed assertions verifying exact size of keys array in two test methods; other test validations remain unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

A date that’s safe in every thread,
UTC time where it’s gently led.
Tests no longer count the keys,
Just check their truth with gentle ease.
Rabbits hop with code so bright,
Thread-safe days and peaceful nights!
🐇⏳

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 39a57c0 and 5e550ec.

📒 Files selected for processing (1)

src/test/java/com/meilisearch/integration/KeysTest.java (0 hunks)

💤 Files with no reviewable changes (1)

src/test/java/com/meilisearch/integration/KeysTest.java

✨ Finishing Touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch chore/fix-tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c80c42b and 548decc.

📒 Files selected for processing (1)

src/main/java/com/meilisearch/sdk/json/GsonKeyTypeAdapter.java (2 hunks)

src/main/java/com/meilisearch/sdk/json/GsonKeyTypeAdapter.java

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/test/java/com/meilisearch/integration/KeysTest.java (1)
48-49: Avoid magic number; use a named constant or result.getTotal()

Hard-coding 4 ties the test to the current Meilisearch default.
When that default shifts again these two tests will break for reasons unrelated to the SDK logic.

A quick refactor keeps the intent while reducing brittleness:
-        assertThat(keys, is(arrayWithSize(4)));
+        final int DEFAULT_KEY_COUNT = 4; // single source of truth
+        assertThat(keys, is(arrayWithSize(DEFAULT_KEY_COUNT)));
(or assertThat(keys.length, is(result.getTotal())) if you want the assertion to track the server).

Same adjustment applies to the Jackson handler test below.

Also applies to: 68-69

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 548decc and b9ecfb5.

📒 Files selected for processing (1)

src/test/java/com/meilisearch/integration/KeysTest.java (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: integration-and-unit-tests

Strift · 2025-07-30T08:45:52Z

@coderabbitai review

coderabbitai · 2025-07-30T08:45:58Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Format date to UTC

548decc

Strift added the maintenance Anything related to maintenance (CI, tests, refactoring...) label Jul 30, 2025

coderabbitai bot reviewed Jul 30, 2025

View reviewed changes

src/main/java/com/meilisearch/sdk/json/GsonKeyTypeAdapter.java Outdated Show resolved Hide resolved

Expect 4 keys instead of 2

b9ecfb5

Strift changed the title ~~Use UTC format for expiredAt date~~ Fix failing tests in Meilisearch 1.16 CI Jul 30, 2025

Strift marked this pull request as draft July 30, 2025 08:02

coderabbitai bot reviewed Jul 30, 2025

View reviewed changes

Make createUtcDateFormat thread-safe

39a57c0

Don't check number of keys

5e550ec

Strift marked this pull request as ready for review July 30, 2025 08:52

Strift merged commit 34e6053 into main Jul 30, 2025
3 checks passed

Strift deleted the chore/fix-tests branch July 30, 2025 08:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix failing tests in Meilisearch 1.16 CI #875

Fix failing tests in Meilisearch 1.16 CI #875

Uh oh!

Strift commented Jul 30, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Jul 30, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

coderabbitai bot left a comment

Uh oh!

Strift commented Jul 30, 2025

Uh oh!

coderabbitai bot commented Jul 30, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Fix failing tests in Meilisearch 1.16 CI #875

Fix failing tests in Meilisearch 1.16 CI #875

Uh oh!

Conversation

Strift commented Jul 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request

Why

What does this PR do?

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jul 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Strift commented Jul 30, 2025

Uh oh!

coderabbitai bot commented Jul 30, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Strift commented Jul 30, 2025 •

edited

Loading

coderabbitai bot commented Jul 30, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)