Skip to content

Conversation

@Strift
Copy link
Collaborator

@Strift Strift commented Dec 12, 2024

Pull Request

Related issue

Fixes #1338

What does this PR do?

  • Update the documentation

Thank you so much for contributing to Meilisearch!

@Strift Strift self-assigned this Dec 12, 2024
@changeset-bot
Copy link

changeset-bot bot commented Dec 12, 2024

⚠️ No Changeset found

Latest commit: c388fd6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Strift Strift requested a review from curquiza December 12, 2024 03:51
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niiiice

bors merge

@meili-bors
Copy link
Contributor

meili-bors bot commented Dec 12, 2024

@meili-bors meili-bors bot merged commit e86b7b3 into main Dec 12, 2024
7 checks passed
@meili-bors meili-bors bot deleted the chore/update-meilisearchparams-docs branch December 12, 2024 13:39
- [`placeholderSearch`](#placeholder-search): Enable or disable placeholder search (default: `true`).
- [`primaryKey`](#primary-key): Specify the primary key of your documents (default `undefined`).
- [`keepZeroFacets`](#keep-zero-facets): Show the facets value even when they have 0 matches (default `false`).
- [`matchingStrategy`](#matching-strategy): Determine the search strategy on words matching (default `last`).

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd remove this line here as well, for clarity, since it doesn't do anything here and only works as one of the meiliSearchParams, thanks!

meili-bors bot added a commit that referenced this pull request Dec 23, 2024
1346: Update `matchingStrategy` docs in autocomplete client README r=brunoocasali a=Strift

This PR:
- Removes documentation about `matchingStrategy` field in `options` (does not exist)
- Removes the section about Matching Strategy for consistency

Follows an incomplete update of documentation made in #1343, and actually fixes #1338

Thanks to `@sgilberg` for the report and review 🙌

Co-authored-by: Strift <[email protected]>
Co-authored-by: Laurent Cazanove <[email protected]>
Co-authored-by: Bruno Casali <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Autocomplete documentation incorrect for matchingStrategy (and other meiliSearchParams)

4 participants