Skip to content

Cast federation payload explicilty to an object #686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Cast federation payload explicilty to an object #686

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0f3a300
Cast federation payload explicilty to an object
thijskuilman Oct 4, 2024
d666c0b
Added HandlesMultiSearchTest and test that no exceptions are thrown w…
thijskuilman Oct 11, 2024
a5fe717
Added HandlesMultiSearchTest and test that no exceptions are thrown w…
thijskuilman Oct 11, 2024
4d6c355
Merge branch 'main' into main
Strift May 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Endpoints/Delegates/HandlesMultiSearch.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public function multiSearch(array $queries = [], ?MultiSearchFederation $federat

$payload = ['queries' => $body];
if (null !== $federation) {
$payload['federation'] = $federation->toArray();
$payload['federation'] = (object) $federation->toArray();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is typecasting necessary? You could use $payload['federation'] = $federation; and it would work just fine.

}

return $this->http->post('/multi-search', $payload);
Expand Down
Loading