-
Notifications
You must be signed in to change notification settings - Fork 63
Use Meilisearch enterprise edition #1072
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThis PR updates Docker image references from the community edition ( Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes These are straightforward configuration updates with repetitive, consistent patterns across files—primarily image tag replacements and minor quote normalization. Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
resources/docker/docker-compose.yaml (1)
10-10: Add:latesttag for consistency with other image references.This file uses
getmeili/meilisearch-enterprisewithout an explicit:latesttag, while other files in the PR (docker-compose.yaml, CONTRIBUTING.md, cypress.yml) explicitly use:latest. For consistency and clarity, add the tag.- image: getmeili/meilisearch-enterprise + image: getmeili/meilisearch-enterprise:latest
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
.github/scripts/beta-docker-version.sh(1 hunks).github/workflows/cypress.yml(1 hunks)CONTRIBUTING.md(1 hunks)docker-compose.yaml(1 hunks)resources/docker/docker-compose.yaml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: Seer Code Review
- GitHub Check: playground-build (Node.js 20)
- GitHub Check: playground-build (Node.js 18)
- GitHub Check: cypress-run
🔇 Additional comments (4)
CONTRIBUTING.md (1)
51-52: Documentation updated consistently with image change.The docker pull and run commands have been updated to reference the enterprise edition. This keeps the contributing guide aligned with the actual setup.
docker-compose.yaml (1)
20-20: Image reference updated correctly.The meilisearch service image has been updated to the enterprise edition with the
:latesttag, consistent with other configuration files in this PR..github/workflows/cypress.yml (1)
13-13: Image reference and quote normalization applied correctly.The service image has been updated to the enterprise edition, and environment variables, ports, and node version have been normalized to double quotes for consistency with GitHub Actions conventions.
Please verify that the enterprise edition image is accessible and functions properly in the GitHub Actions CI environment. If the image has different authentication or network requirements, those should be configured in the workflow.
Also applies to: 15-16, 18-18, 26-26
.github/scripts/beta-docker-version.sh (1)
7-7: Docker Hub endpoint updated for enterprise image tag detection.The script now queries the enterprise edition tags endpoint. The parsing logic remains unchanged, so this should work correctly as long as the enterprise edition publishes tags to the same Docker Hub endpoint with the same response format.
Verify that
getmeili/meilisearch-enterprise/tagsendpoint on Docker Hub is accessible and returns tags in the same format as the community edition. If the response format differs, the parsing logic may need adjustment.
Starting from Meilisearch v1.28, the community and enterprise editions of Meilisearch have distinct binaries.
To allow full-feature coverage, this PR updates the repository to test against the enterprise edition instead of the default community edition by using the
getmeili/meilisearch-enterpriseDocker image.PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!
Summary by CodeRabbit
Chores
Documentation
✏️ Tip: You can customize this high-level summary in your review settings.