Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# spring-service

## 5.2.0

- Allow to disable environment variable service links using `enableServiceLinks: false`

## 5.1.1

- Remove now unnecessary, confusing Helm chart labels on prom resources
Expand Down
2 changes: 1 addition & 1 deletion charts/spring-service/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
apiVersion: v1
name: spring-service
description: A generalized deployment for Meisterplan Spring Boot services in Kubernetes.
version: 5.1.1
version: 5.2.0
1 change: 1 addition & 0 deletions charts/spring-service/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ spec:
operator: In
values:
- {{ .Values.image.tag | quote }}
enableServiceLinks: {{ .Values.enableServiceLinks }}
containers:
- name: {{ .Values.serviceName }}
image: "{{ required "repository must be set!" .Values.image.repository }}:{{ required "tag must be set!" .Values.image.tag }}"
Expand Down
3 changes: 3 additions & 0 deletions charts/spring-service/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,9 @@ disruptionBudget:
type: maxUnavailable # either "maxUnavailable" (terminate at most this many pods) or "minAvailable" (have at least this many running pods remaining)
value: 1 # value with reference to type

# Set to false to disable service link environment variables
enableServiceLinks: true

# Allow additional manifest to be deployed with the chart
extraManifests: []
# - apiVersion: v1
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ spec:
operator: In
values:
- "1.30.7"
enableServiceLinks: false
containers:
- name: myservice
image: "docker.pkg.github.com/my-company/myservice:1.30.7"
Expand Down
4 changes: 3 additions & 1 deletion tests/spring-service/complex-service/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ ingress:
- /welcome
- /index.html
additionalHosts:
- "myservice.othercompany.tld"
- "myservice.othercompany.tld"
oauth2ProxyProtected: true
overwriteCustomHttpErrors: "502"

Expand All @@ -42,6 +42,8 @@ disruptionBudget:
type: minAvailable
value: "50%"

enableServiceLinks: false

extraManifests:
- apiVersion: v1
kind: ConfigMap
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ spec:
operator: In
values:
- "1.30.7"
enableServiceLinks: true
containers:
- name: myservice
image: "docker.pkg.github.com/my-company/myservice:1.30.7"
Expand Down