O3-5343: Support Billing v2 in the Initializer module #311
Conversation
|
For domains, please just keep them in the API folder unless there's some reason that won't work. We can set the |
| import org.openmrs.module.initializer.api.loaders.BaseCsvLoader; | ||
| import org.springframework.beans.factory.annotation.Autowired; | ||
|
|
||
| @OpenmrsProfile(modules = { "billing:1.1.0 - 9.*" }) |
There was a problem hiding this comment.
| @OpenmrsProfile(modules = { "billing:1.1.0 - 9.*" }) | |
| @OpenmrsProfile(modules = { "billing:2.0.0 - 9.*" }) |
| import org.springframework.beans.factory.annotation.Autowired; | ||
| import org.springframework.beans.factory.annotation.Qualifier; | ||
|
|
||
| @OpenmrsProfile(modules = { "billing:2.0.0 - 9.*" }) |
There was a problem hiding this comment.
Since you mentioned "Billing v2 now requires OpenMRS Core 2.7.8-SNAPSHOT”, shouldn’t we add that requirement as well?
There was a problem hiding this comment.
No need to add that. Billing module won't even start if we are using a core version lower than 2.7.8-SNAPSHOT
There was a problem hiding this comment.
Billing module won't even start if we are using a core version lower than 2.7.8-SNAPSHOT
I understand that. Won’t it be better to add that, especially since this requirement would get documented.
| { | ||
| // To be edited | ||
| PaymentMode paymentMode = new PaymentMode(); | ||
| paymentMode.setUuid("526bf278-ba81-4436-b867-c2f6641d060a"); | ||
| paymentMode.setName("Visa Card"); | ||
| paymentMode.setRetired(false); | ||
| } | ||
|
|
||
| { | ||
| // To be retired | ||
| PaymentMode paymentMode = new PaymentMode(); | ||
| paymentMode.setUuid("2b1b9aae-5d35-43dd-9214-3fd370fd7737"); | ||
| paymentMode.setName("Bank transfer"); | ||
| paymentMode.setRetired(false); | ||
| } |
There was a problem hiding this comment.
Should these two call the save function?
There was a problem hiding this comment.
I just copied this test from the api-2.4. I don't think we need these, so I am removing them.
@ibacher I didn’t quite understand what you meant about domains. Could you clarify a bit? |
|
Basically, unless we actually need to directly call an API in core-2.7, the code for billing should just be in the api folder. Domains are the units Iniz works with. |
So Billing v1 is currently in api-2.4. Are you suggesting we should move Billing v2 to the api module, even though it’s based on OpenMRS Platform 2.1? |
3 participants
This addresses the following items required for the migration: