LAMP-49: Add scheduler to complete programs #5
Conversation
VaishSiddharth
changed the title
VaishSiddharth
changed the title
|
Asking review from @corneliouzbett since I'm not the best person to review this backend code. |
| import java.util.List; | ||
| import static org.junit.Assert.assertNotNull; | ||
| import org.mockito.Mockito; | ||
| import static org.mockito.Mockito.*; |
| <dependency> | ||
| <groupId>org.openmrs.api</groupId> | ||
| <artifactId>openmrs-api</artifactId> | ||
| <version>${openmrsPlatformVersion}</version> |
There was a problem hiding this comment.
Looks like you are using a lower version of OpenMRS platform v2.4.0. You should be targetting 2.7.x
| import java.util.Date; | ||
|
|
||
| import org.junit.Before; | ||
| import org.junit.Test; |
There was a problem hiding this comment.
I would recommend writing tests using JUnit 5
There was a problem hiding this comment.
Cannot use JUnit5 because PowerMock is not officially supported by JUnit 5
There was a problem hiding this comment.
You need to get rid of PowerMock in favor of mockStatic from Mockito library
| <comment>Inserting CompletePrograms Task into 'schedule_task_config' table</comment> | ||
| <insert tableName="scheduler_task_config"> | ||
| <column name="name" value="Complete LAMP Program Task" /> | ||
| <column name="description" value="Completes open Programs in Ozone LAMP" /> |
There was a problem hiding this comment.
Can this module be used outside Ozone Lamp distro? If yes, let's remove 'Ozone Lamp' in the description.
There was a problem hiding this comment.
Not really. This module is tied to Ozone LAMP programs.
There was a problem hiding this comment.
This class shouldn't be a Spring bean but rather just a constants Class.
| <changeSet id="create-complete-program-task-2025-11-04" author="siddharth"> | ||
| <preConditions onFail="MARK_RAN"> | ||
| <sqlCheck expectedResult="0"> | ||
| SELECT COUNT(*) FROM scheduler_task_config | ||
| WHERE schedulable_class = 'org.openmrs.module.lamp.scheduler.CompleteProgramsTask' | ||
| And name = 'Complete LAMP Program Task' | ||
| </sqlCheck> | ||
| </preConditions> | ||
| <comment>Inserting CompletePrograms Task into 'schedule_task_config' table</comment> | ||
| <insert tableName="scheduler_task_config"> |
There was a problem hiding this comment.
At some point, I would like us to migrate from using this approach (built-in scheduled task engine). This is because if the module is removed for some reason, there will be always scheduled task configuration hanging around, which throws errors due to classes not being found
There was a problem hiding this comment.
@VaishSiddharth can you revert (last commit) to using JUnit 4. Let's have a follow up task to migrate to JUnit 5.
VaishSiddharth
force-pushed
the
complete-program-scheduler
branch
from
abe9f5d to
0dcf8e4
Compare
3 participants
JIRA: https://mekomsolutions.atlassian.net/browse/LAMP-49