Open
Conversation
In incorporating melange-jest into my workflow, I had to dig a little into how people are using it in their dune workflows. melange-json follows the sensible practice I described in this PR,
anmonteiro
reviewed
Sep 10, 2024
README.md
Outdated
Comment on lines
107
to
108
| (deps | ||
| (alias_rec test)) |
Member
There was a problem hiding this comment.
I don't think this is needed, right? seems somewhat specific to your setup
Author
There was a problem hiding this comment.
yeah good point, not necessary; i updated the PR with a separate alias for jest instead, leave it up to others whether they want to try to hook into other aliases like runtest.
Member
|
@andrewbaine I think it was fine to have the |
Author
|
okay, i'll add that back in there, 1 moment |
Author
|
@anmonteiro I was playing around with this a little more. Let me try one more crack at describing a setup correctly, then I'll edit according to what you like best. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In incorporating melange-jest into my workflow, I had to dig a little into how people are using it in their dune workflows. melange-json follows the practice I described in this PR.