Support parallel read #395
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Parallel Processing Fixes:** - Fix missing attribute hyperlinks in parallel builds - Fix missing attribute content rendering in worker processes - Ensure attribute definitions are properly shared between worker processes - Improve collection merging logic for robust parallel processing **API Improvements:** - Simplify add_attribute() API - no longer requires explicit collection parameter - Items automatically get collection reference when added to collection - Maintain backward compatibility with existing code - Add comprehensive validation while improving user experience **Test Suite Enhancements:** - Add comprehensive parallel processing test suite - Consolidate duplicate test files into unified test suite - Add tests for attribute consistency between serial/parallel builds - Improve test coverage for edge cases and error handling - Enhanced `ParallelSafeTraceableCollection` for proper worker process handling - Improved `begin_parallel_read()` to ensure all attribute definitions available - Enhanced `merge_from()` logic for robust collection merging - Modified `add_item()` to automatically set collection reference - Updated multiple directive classes for consistent parallel behavior - Resolves attribute hyperlink generation in parallel builds - Resolves attribute content rendering issues - Eliminates duplicate warnings in parallel processing - Maintains data integrity across worker processes
3 new issues
|
![qltysh[bot]](https://avatars.githubusercontent.com/in/890766?s=60&v=4){kind=small}
|
Diff Coverage: The code coverage on the diff in this pull request is 78.5%. Total Coverage: This PR will increase coverage by 12.21%. File Coverage Changes
🛟 Help
|
Letme
approved these changes
Jul 25, 2025
…rror: <class 'sphinx.writers.html5.HTML5Translator'> departing unknown node type: AttributeSort'
Resolves serial build failures where utility nodes (AttributeSort, CheckboxResult, ItemLink, ItemRelink, AttributeLink) were processed by HTML5 translator before being replaced by replace_self([]). - Register utility nodes with app.add_node() for proper Sphinx integration - Use docutils.nodes.SkipNode to cleanly skip nodes with no visual representation - Single skip_node_html5() function handles all utility nodes consistently - Fixes NotImplementedError in serial builds (-j 1) while maintaining parallel support Closes: Serial build crash with 'departing unknown node type' error
|
The doc build in CI produces some duplicate warnings. No clue why yet. I will investigate this issue and have a look at sphinx-doc/sphinx#13738. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #269