Skip to content

Comments

fix(package-build.el): Resolve all select coding system on Windows#93

Closed
jcs090218 wants to merge 1 commit intomelpa:masterfrom
jcs-PR:fix/select-coding-win
Closed

fix(package-build.el): Resolve all select coding system on Windows#93
jcs090218 wants to merge 1 commit intomelpa:masterfrom
jcs-PR:fix/select-coding-win

Conversation

@jcs090218
Copy link
Contributor

Similar to #70. 🤔

@purcell
Copy link
Member

purcell commented Dec 22, 2025

Closing as per the linked PR.

@purcell purcell closed this Dec 22, 2025
@jcs090218
Copy link
Contributor Author

Could you point me to where this is addressed? 🤔 These should be handled in different places.

@purcell
Copy link
Member

purcell commented Dec 30, 2025

The point is that we don't edit package-build in this repo: any changes would be made upstream, and the linked issue there was closed. Once #94 is considered, then if it's merged it would subsequently need to be propagated here via the git subtree.

@tarsius
Copy link
Member

tarsius commented Jan 3, 2026

The point is that we don't edit package-build in this repo:

Yes we do. You are commenting on a pull-request in melpa/package-build.
#93 (this pr) is located in the same repository as #94 (the one you said was a good idea). 🤪

@jcs090218
Copy link
Contributor Author

Ah, I was a little confused, but I think I know the problem now. 😉

@jcs090218 jcs090218 deleted the fix/select-coding-win branch January 3, 2026 16:01
@purcell
Copy link
Member

purcell commented Jan 3, 2026

Yes we do. You are commenting on a pull-request in melpa/package-build.

You can see how well my Christmas holiday brain is working, haha!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants