Skip to content

avoid throwing notices for undefined index #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
scor wants to merge 1 commit into
base: master
Choose a base branch
from
Open

avoid throwing notices for undefined index #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions lib/Authentication_FoafSSLDelegate.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,16 +61,16 @@ class Authentication_FoafSSLDelegate {

const STATUS_AUTH_VIA_SESSION =
"Authenticated via a session";

const STATUS_DELEGATED_LOGIN_OK =
"Delegated FOAF Login response has been authenticated";

const STATUS_SIGNATURE_VERIFICATION_ERR =
"Signature on response could not be verified";

const STATUS_UNSUPPORTED_SIGNATURE_ALG_ERR =
"Unsupported signature algorithm";

const STATUS_IDP_RESPONSE_TIMEOUT_ERR =
"Response from delegate IdP was outside of the allowed time window";

Expand Down Expand Up @@ -120,17 +120,16 @@ public function __construct($createSession = TRUE,
);
}

if (!empty($_GET["error"]))
$error = $request->getQueryParameter('error', $_GET["error"]);
$sig = $request->getQueryParameter('sig', $_GET["sig"]);
$ts = $request->getQueryParameter('ts', $_GET["ts"]);
$error = $request->getQueryParameter('error', isset($_GET["error"]) ? $_GET["error"] : NULL);
$sig = $request->getQueryParameter('sig', isset($_GET["sig"]) ? $_GET["sig"] : NULL);
$ts = $request->getQueryParameter('ts', isset($_GET["ts"]) ? $_GET["ts"] : NULL);

$this->requestURI = $request;
$this->referer = NULL != $referer ?
$referer :
Authentication_URL::parse($_GET["referer"]);
$this->ts = $ts;
$this->webid = $request->getQueryParameter('webid', $_GET["webid"]);
$this->webid = $request->getQueryParameter('webid', isset($_GET["webid"]) ? $_GET["webid"] : NULL);
$this->allowedTimeWindow = $allowedTimeWindow;

$this->elapsedTime = time() - strtotime($ts);
Expand Down