Skip to content

Add log for mismatching content-type #2264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
christiangoerdes wants to merge 4 commits into from
Closed

Add log for mismatching content-type #2264

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f02b2d8
add guard for empty body / wrong / no content type
christiangoerdes Nov 4, 2025
1cd5a00
set log level to info
christiangoerdes Nov 4, 2025
512bacd
code improvements
christiangoerdes Nov 4, 2025
06a9870
requested changes
christiangoerdes Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions core/src/main/java/com/predic8/membrane/core/lang/xpath/XPathExchangeExpression.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,10 @@
import javax.xml.namespace.*;
import javax.xml.xpath.*;

import java.io.IOException;

import static com.predic8.membrane.core.util.XMLUtil.*;
import static java.lang.Boolean.FALSE;
import static javax.xml.xpath.XPathConstants.*;

public class XPathExchangeExpression extends AbstractExchangeExpression {
Expand All @@ -41,6 +44,18 @@ public XPathExchangeExpression(String xpath) {
@Override
public <T> T evaluate(Exchange exchange, Interceptor.Flow flow, Class<T> type) {
Message msg = exchange.getMessage(flow);

// Guard against empty body and other Content-Types
try {
if (msg.isBodyEmpty() || !msg.isXML()) {
log.debug("Body is empty or Content-Type not XML. Nothing to evaluate for expression: {}", expression);
return resultForNoEvaluation(type);
}
} catch (IOException e) {
log.error("Error checking if body is empty", e);
return resultForNoEvaluation(type);
}

try {
if (Boolean.class.isAssignableFrom(type)) {
return type.cast( evalutateAndCast(msg, BOOLEAN));
Expand Down Expand Up @@ -75,4 +90,14 @@ private Object evalutateAndCast(Message msg, QName xmlType) throws XPathExpressi
// XPath is not thread safe! Therefore every time the factory is called!
return factory.newXPath().evaluate(expression, getInputSource(msg), xmlType);
}

private <T> T resultForNoEvaluation(Class<T> type) {
if (String.class.isAssignableFrom(type)) {
return type.cast("");
}
if (Boolean.class.isAssignableFrom(type)) {
return type.cast(FALSE);
}
return type.cast(new Object());
}
}