Fix order of handle_child_terminated and handle_crash_group_down callback invocation #962
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e handle_crash_group_down. Add test checking that. Fix a formatting issue in documentation for the testing pipeline
mat-hek
approved these changes
Apr 8, 2025
FelonEkonom
approved these changes
Apr 8, 2025
Comment on lines
69
to
79
| def maybe_detonate_crash_group(_child_name, %CrashGroup{} = _group, :normal, state), do: state | ||
|
|
||
| def maybe_detonate_crash_group( | ||
| _child_name, | ||
| %CrashGroup{detonating?: true} = _group, | ||
| _crash_reason, | ||
| state | ||
| ), | ||
| do: state | ||
|
|
||
| def maybe_detonate_crash_group(crash_initiator, %CrashGroup{} = group, crash_reason, state) do |
Member
There was a problem hiding this comment.
you can match on detonating?: false and add a guard reason != :normal to have 2 cases instead of 3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
handle_child_terminatedcallbacks for children in crash group are called beforehandle_crash_group_downof that groupTODO:
handle_child_terminated