Handle case when ex_hls has to add some latency to Live HLS stream#119
Merged
FelonEkonom merged 4 commits intomasterfrom Sep 22, 2025
Merged
Handle case when ex_hls has to add some latency to Live HLS stream#119FelonEkonom merged 4 commits intomasterfrom
FelonEkonom merged 4 commits intomasterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR handles cases when ExHLS needs to add latency to Live HLS streams by implementing proper asynchronous initialization of the ClientGenServer. Instead of blocking during initialization, the source element now waits for the ClientGenServer to be ready before proceeding with streaming operations.
Key changes:
- Introduces asynchronous ClientGenServer initialization with timeout handling
- Updates ExHLS dependency from 0.1.0 to 0.1.2
- Adds proper state management for ClientGenServer readiness
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| lib/membrane_http_adaptive_stream/source.ex | Implements asynchronous ClientGenServer initialization with new status states and timeout handling |
| lib/membrane_http_adaptive_stream/source/client_genserver.ex | Updates message name sent when ClientGenServer is ready |
| mix.exs | Updates ExHLS dependency version and project version |
| README.md | Updates installation version in documentation |
| test/membrane_http_adaptive_stream/integration_test/source_test.exs | Adds test tag and comments out sleep duration |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
test/membrane_http_adaptive_stream/integration_test/source_test.exs
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.