Merged
Conversation
varsill
requested changes
Nov 25, 2025
lib/transcoder/video.ex
Outdated
| end | ||
|
|
||
| defp maybe_plug_swscale_converter(builder, input_format, output_format) do | ||
| # output pixel format is nil when the transcoder outptu format was set to |
Collaborator
There was a problem hiding this comment.
Suggested change
| # output pixel format is nil when the transcoder outptu format was set to | |
| # output pixel format is nil when the transcoder output format was set to |
test/integration_test.exs
Outdated
Comment on lines
40
to
43
| if test_case.input_format == RawVideo and | ||
| test_case.output_format == {RawVideo, pixel_format: :RGB} do | ||
| @tag :xd | ||
| end |
Collaborator
There was a problem hiding this comment.
Something is either missing here or it's a leftover ;D
lib/transcoder/video.ex
Outdated
| end | ||
|
|
||
| defp pixel_format(%RawVideo{pixel_format: pixel_format}), do: pixel_format | ||
| defp pixel_format(_encoded_video), do: :I420 |
Collaborator
There was a problem hiding this comment.
It's quite a strong assumption that encoded video's pixel format of the input is :I420
varsill
approved these changes
Nov 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.