Rename signaling channel to signaling #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mat-hek
requested changes
Feb 19, 2025
Comment on lines
-24
to
-29
| @type t :: %__MODULE__{pid: pid()} | ||
|
|
||
| @typedoc """ | ||
| Messages sent by the signaling channel to the peer. | ||
| """ | ||
| @type message :: {__MODULE__, pid(), message_content, metadata :: map} |
Member
There was a problem hiding this comment.
Now I'm a bit concerned about these types, message in particular. Previously they were {SignalingChannel, , now they are {Signaling, }, so it may break people's code :/
Member
Author
There was a problem hiding this comment.
Do you think about Boombox, or about the community?
Member
Author
There was a problem hiding this comment.
Should we really care about it? The minor is bumped and I guess that the only things that use the messages in the form of {Signaling | SignalingChannel, pid, ...} are Boombox and WebRTC components that I am currently working on
mat-hek
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.