-
Notifications
You must be signed in to change notification settings - Fork 12
Add ex_webrtc options to Source and Sink #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ex_webrtc options to Source and Sink #24
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good to me, in comments there are just minor typespec changes.
Thank you for your contribution! 👍
|
@kingdomcoding @avrininnovations I will release your changes in |
|
@kingdomcoding @avrininnovations your changes are released now on hex.pm |
As per the
ex_webrtcdocs for bare deployment,ice_port_rangemight need to be set:And as per the
ex_webrtcdocs for Fly.io deployment,ice_ip_filtermight need to be set:This PR adds the
ice_port_rangeandice_ip_filteroptions to the source and sink elements/bins