Skip to content

Conversation

@avrininnovations
Copy link
Contributor

@avrininnovations avrininnovations commented Mar 10, 2025

As per the ex_webrtc docs for bare deployment, ice_port_range might need to be set:

PeerConnection.start_link(ice_port_range: 50_000..60_000)

And as per the ex_webrtc docs for Fly.io deployment, ice_ip_filter might need to be set:

ip_filter = Application.get_env(:your_app, :ice_ip_filter)

{:ok, pc} =
  PeerConnection.start_link(
    ice_ip_filter: ip_filter,
    ice_servers: [%{urls: "stun:stun.l.google.com:19302"}]
  )

This PR adds the ice_port_range and ice_ip_filter options to the source and sink elements/bins

@mat-hek mat-hek requested a review from FelonEkonom March 14, 2025 09:53
Copy link
Member

@FelonEkonom FelonEkonom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me, in comments there are just minor typespec changes.

Thank you for your contribution! 👍

@FelonEkonom FelonEkonom self-assigned this Mar 24, 2025
@FelonEkonom FelonEkonom moved this to In Review in Smackore Mar 24, 2025
@FelonEkonom FelonEkonom self-requested a review March 27, 2025 13:09
@FelonEkonom FelonEkonom merged commit cd8cfe4 into membraneframework:master Mar 27, 2025
@github-project-automation github-project-automation bot moved this from In Review to Done in Smackore Mar 27, 2025
@FelonEkonom
Copy link
Member

@kingdomcoding @avrininnovations I will release your changes in membrane_webrtc_plugin v0.25.1 soon

@FelonEkonom
Copy link
Member

@kingdomcoding @avrininnovations your changes are released now on hex.pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants