LiveView for establishing WebRTC connections #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varsill
requested changes
Mar 20, 2025
Contributor
There was a problem hiding this comment.
I think there is a mismatch between the example name (live_view) and the Phoenix project name used for an actual example (example_project) which resonates throughout the READMEs etc. The best thing would be to generate a new Phoenix project with the desired project name live_view.
Another thing is that you might consider calling you example live_view_signaling instead of live_view, as it aligns more to the rest of exemplary project names
Co-authored-by: Łukasz Kita <lukasz.kita0@gmail.com>
Co-authored-by: Łukasz Kita <lukasz.kita0@gmail.com>
Co-authored-by: Łukasz Kita <lukasz.kita0@gmail.com>
Co-authored-by: Łukasz Kita <lukasz.kita0@gmail.com>
Co-authored-by: Łukasz Kita <lukasz.kita0@gmail.com>
Co-authored-by: Łukasz Kita <lukasz.kita0@gmail.com>
Co-authored-by: Łukasz Kita <lukasz.kita0@gmail.com>
Co-authored-by: Łukasz Kita <lukasz.kita0@gmail.com>
Co-authored-by: Łukasz Kita <lukasz.kita0@gmail.com>
Co-authored-by: Łukasz Kita <lukasz.kita0@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.