Get rid of Boombox from LiveView example #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 19 out of 37 changed files in this pull request and generated no comments.
Files not reviewed (18)
- examples/live_view/.formatter.exs: Language not supported
- examples/live_view/.gitignore: Language not supported
- examples/live_view/config/config.exs: Language not supported
- examples/live_view/config/dev.exs: Language not supported
- examples/live_view/config/prod.exs: Language not supported
- examples/live_view/config/runtime.exs: Language not supported
- examples/live_view/config/test.exs: Language not supported
- examples/live_view/lib/example_project_web/router.ex: Language not supported
- examples/live_view/lib/webrtc_live_view.ex: Language not supported
- examples/live_view/lib/webrtc_live_view/application.ex: Language not supported
- examples/live_view/lib/webrtc_live_view/pipeline.ex: Language not supported
- examples/live_view/lib/webrtc_live_view_web.ex: Language not supported
- examples/live_view/lib/webrtc_live_view_web/components/layouts.ex: Language not supported
- examples/live_view/lib/webrtc_live_view_web/components/layouts/app.html.heex: Language not supported
- examples/live_view/lib/webrtc_live_view_web/components/layouts/root.html.heex: Language not supported
- examples/live_view/lib/webrtc_live_view_web/controllers/error_html.ex: Language not supported
- examples/live_view/lib/webrtc_live_view_web/controllers/error_json.ex: Language not supported
- examples/live_view/lib/webrtc_live_view_web/controllers/page_controller.ex: Language not supported
varsill
reviewed
Apr 7, 2025
examples/live_view/assets/js/app.js
Outdated
| let Hooks = {}; | ||
| const iceServers = [{ urls: "stun:stun.l.google.com:19302" }]; | ||
|
|
||
| let Hooks = {}; |
Contributor
There was a problem hiding this comment.
I think the changes from the contour demo are not applied here, so please rename it to lowercase hooks
examples/live_view/README.md
Outdated
|
|
||
| * Run `mix setup` to install and setup dependencies | ||
| * Start Phoenix with `mix phx.server` or inside IEx with `iex -S mix phx.server` | ||
| * Start Phoenix endpoint with `mix phx.server` or inside IEx with `iex -S mix phx.server` |
Contributor
There was a problem hiding this comment.
we are starting Phoenix server, not only Phoenix endpoint with that command
Contributor
There was a problem hiding this comment.
since it's just handle_init here, perhaps it would be better to use RCPipeline?
Member
Author
There was a problem hiding this comment.
Yes, it could be used, but for me it looks better to define Pipeline module in demos than to use RCPipeline, because it is more conventional way of using Membrane
FelonEkonom
changed the title
FelonEkonom
changed the title
varsill
approved these changes
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.