Skip to content

Refactor recent community PR#38

Merged
FelonEkonom merged 3 commits intomasterfrom
refactor-start-link
Feb 17, 2026
Merged

Refactor recent community PR#38
FelonEkonom merged 3 commits intomasterfrom
refactor-start-link

Conversation

@FelonEkonom
Copy link
Member

No description provided.

@FelonEkonom FelonEkonom changed the title Refactor start_link Refactor recent community PR Feb 17, 2026
@FelonEkonom FelonEkonom self-assigned this Feb 17, 2026
@FelonEkonom FelonEkonom requested a review from Copilot February 17, 2026 13:52
@FelonEkonom FelonEkonom moved this to In Progress in Smackore Feb 17, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the Signaling module API by introducing a new Signaling.new/1 function to properly separate GenServer process spawning from struct wrapping. This addresses an issue where the previous implementation of directly instantiating %Signaling{pid: signaling_pid} could lead to orphaned processes when not properly supervised.

Changes:

  • Added Signaling.new/1 function to wrap an already-spawned Signaling GenServer pid in a struct
  • Updated all internal usages to call Signaling.new(signaling_pid) instead of direct struct instantiation
  • Enhanced documentation for new/0, new/1, and start_link/1 functions
  • Bumped version from 0.26.2 to 0.26.3

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
mix.exs Version bump from 0.26.2 to 0.26.3
README.md Updated dependency version reference to 0.26.3
lib/membrane_webrtc/signaling.ex Added new/1 function with documentation, improved docs for existing functions
lib/membrane_webrtc/simple_websocket_server.ex Replaced direct struct instantiation with Signaling.new/1 call
lib/membrane_webrtc/ex_webrtc/source.ex Replaced direct struct instantiation with Signaling.new/1 call
lib/membrane_webrtc/ex_webrtc/sink.ex Replaced direct struct instantiation with Signaling.new/1 call

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@FelonEkonom FelonEkonom merged commit 25f25b4 into master Feb 17, 2026
0 of 3 checks passed
@FelonEkonom FelonEkonom deleted the refactor-start-link branch February 17, 2026 13:58
@github-project-automation github-project-automation bot moved this from In Progress to Done in Smackore Feb 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants