Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the Signaling module API by introducing a new Signaling.new/1 function to properly separate GenServer process spawning from struct wrapping. This addresses an issue where the previous implementation of directly instantiating %Signaling{pid: signaling_pid} could lead to orphaned processes when not properly supervised.
Changes:
- Added
Signaling.new/1function to wrap an already-spawned Signaling GenServer pid in a struct - Updated all internal usages to call
Signaling.new(signaling_pid)instead of direct struct instantiation - Enhanced documentation for
new/0,new/1, andstart_link/1functions - Bumped version from 0.26.2 to 0.26.3
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| mix.exs | Version bump from 0.26.2 to 0.26.3 |
| README.md | Updated dependency version reference to 0.26.3 |
| lib/membrane_webrtc/signaling.ex | Added new/1 function with documentation, improved docs for existing functions |
| lib/membrane_webrtc/simple_websocket_server.ex | Replaced direct struct instantiation with Signaling.new/1 call |
| lib/membrane_webrtc/ex_webrtc/source.ex | Replaced direct struct instantiation with Signaling.new/1 call |
| lib/membrane_webrtc/ex_webrtc/sink.ex | Replaced direct struct instantiation with Signaling.new/1 call |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.