draft: why std::this_thread::sleep_for() is broken on ESP32#544
Merged
gminn merged 2 commits intomemfault:masterfrom Feb 19, 2025
Merged
draft: why std::this_thread::sleep_for() is broken on ESP32#544gminn merged 2 commits intomemfault:masterfrom
gminn merged 2 commits intomemfault:masterfrom
Conversation
Member
|
@stevenoonan Thank you for submitting an article! We're really excited to review this. Could you send us an email at interrupt@memfault.com, so we can coordinate the review process and agree on a publish date? |
gminn
approved these changes
Feb 18, 2025
Member
gminn
left a comment
gminn
left a comment
There was a problem hiding this comment.
This is a fantastic walk-through, thank you @stevenoonan! I also love that it ends in a PR, which 🤞 hopefully gets reviewed/merged. I think this is publish-ready, with only quick grammar pass on our end to polish it up.
Contributor
Author
|
Yeah, I really hope the PR gets merged. Maybe publishing this will put some heat on it! 🔥 |
Member
Merge activity
|
Member
|
Hi Steve,
I merged your draft and put up a publish PR
<#554> with some minor changes.
Can you review, and let me know what you think?
Best,
Gilly
…On Tue, Feb 18, 2025 at 7:54 PM Steve Noonan ***@***.***> wrote:
Yeah, I really hope the PR gets merged. Maybe publishing this will put
some heat on it! 🔥
—
Reply to this email directly, view it on GitHub
<#544 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJY7HLX4PGELUB2YESM5TID2QPI2TAVCNFSM6AAAAABVFVBCGWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNRXGI2TEOBXG4>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
[image: stevenoonan]*stevenoonan* left a comment (memfault/interrupt#544)
<#544 (comment)>
Yeah, I really hope the PR gets merged. Maybe publishing this will put
some heat on it! 🔥
—
Reply to this email directly, view it on GitHub
<#544 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJY7HLX4PGELUB2YESM5TID2QPI2TAVCNFSM6AAAAABVFVBCGWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNRXGI2TEOBXG4>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found a strange bug when I upgraded an ESP32 project to a new IDF version. It revealed quite an unexpected interaction between C++ and C standard libraries on the ESP32, and resulted in me making a PR to the ESP IDF newlib code. I thought it would make a good article.
I'm happy to make additional edits, but I am hopeful it is close to its final form.