Skip to content

content: linux coredumps#545

Merged
bahildebrand merged 7 commits intomasterfrom
blake/linux-coredumps
Feb 13, 2025
Merged

content: linux coredumps#545
bahildebrand merged 7 commits intomasterfrom
blake/linux-coredumps

Conversation

@bahildebrand
Copy link
Member

Summary

Add an article covering the cause, layout, and use
of Linux coredumps in memfaultd.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jan 14, 2025

Deploying interrupt with  Cloudflare Pages  Cloudflare Pages

Latest commit: ad41ae5
Status: ✅  Deploy successful!
Preview URL: https://288462f9.interrupt.pages.dev
Branch Preview URL: https://blake-linux-coredumps.interrupt.pages.dev

View logs

 ### Summary

Add an article covering the cause, layout, and use
of Linux coredumps in `memfaultd`.
@bahildebrand bahildebrand marked this pull request as ready for review February 11, 2025 15:34
@bahildebrand bahildebrand requested a review from a team as a code owner February 11, 2025 15:34
Copy link
Member

@gminn gminn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass!

bahildebrand and others added 2 commits February 12, 2025 15:03
Co-authored-by: Gillian Minnehan <41022382+gminn@users.noreply.github.com>
Copy link
Member

@gminn gminn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐧

bahildebrand and others added 4 commits February 13, 2025 10:16
Co-authored-by: François Baldassari <franc0is@users.noreply.github.com>
Co-authored-by: Gillian Minnehan <41022382+gminn@users.noreply.github.com>
Co-authored-by: François Baldassari <franc0is@users.noreply.github.com>
@bahildebrand bahildebrand merged commit 82a3948 into master Feb 13, 2025
1 check passed
@bahildebrand bahildebrand deleted the blake/linux-coredumps branch February 13, 2025 16:48
Copy link
Contributor

@sarfata sarfata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff!

information about crashed processes, add metadata that helps gives us
information the device in question, and do all of this without making any source
modifications to anything running on the system. For this reason our first pass
at coredumps leave them largely untouched from what the kernel provides. The
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left them largely...?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was your question here? (maybe blake fixed it)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gminn I thought the grammar was bad and I would have written "For this reason our first pass
at coredumps leaves them largely untouched from what the kernel provides." or "For this reason our first pass
at coredumps left them largely untouched from what the kernel provides."

Claude agrees:
image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're completely right! Actually, our grammarly pass picked this up as well and I just didn't connect the dots with your comment. ty for keeping an eye out for grammar, and following up 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants