Fix parameter names for path functions #993
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace minLevel/maxLevel by minHops/maxHops
|
@thomas-tran-de is attempting to deploy a commit to the Memgraph Team on Vercel. A member of the Team first needs to authorize it. |
katarinasupe
requested review from
imilinovic
and removed request for
hal-eisen-MG
Contributor
|
@imilinovic does this PR make sense? (since you worked on the path module) |
imilinovic
approved these changes
Nov 5, 2024
Contributor
imilinovic
left a comment
imilinovic
left a comment
There was a problem hiding this comment.
Looked at the code, this is correct, nice catch!
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
|
Thank you @thomas-tran-de for the contribution! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace minLevel/maxLevel by minHops/maxHops
Description
The documentation still listed the old parameter names for path functions. This PR changes them
Pull request type
Please check what kind of PR this is: