Skip to content

Build MAGE modules with ninja #694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into from
Open

Build MAGE modules with ninja #694

wants to merge 3 commits into from
+44 −48

Conversation

@mattkjames7
Copy link
Contributor

@mattkjames7 mattkjames7 commented Nov 13, 2025 •
edited
Loading

Save about 3 seconds per build by using Ninja to build C++ modules!

Also fix a few deprecation warnings from Rust.

@mattkjames7 mattkjames7 self-assigned this Nov 13, 2025
@mattkjames7 mattkjames7 added infrastructure Docs unnecessary Docs unnecessary Docs needed Docs needed and removed Docs unnecessary Docs unnecessary labels Nov 13, 2025
@mattkjames7 mattkjames7 added this to the mage-v3.8.0 milestone Nov 13, 2025
@mattkjames7
Copy link
Contributor Author

mattkjames7 commented Dec 4, 2025 •
edited
Loading

Description

Save about 3 seconds per build by using Ninja to build C++ modules!

Also fix a few deprecation warnings from Rust.

Pull request type

  • Bugfix
  • Algorithm/Module
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

######################################

Reviewer checklist (the reviewer checks this part)

Module/Algorithm

  • Core algorithm/module implementation
  • Query module implementation
  • Tests provided (unit / e2e)
  • Code documentation
  • README short description

Documentation checklist

  • Add the documentation label tag
  • Add the bug / feature label tag
  • Add the milestone for which this feature is intended
    • If not known, set for a later milestone
  • Write a release note, including added/changed clauses
    • Build using ninja-build and tidy up some warnings #694.
  • Link the documentation PR here

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 4, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@mattkjames7 mattkjames7 mentioned this pull request Dec 4, 2025
Draft
11 tasks
@mattkjames7 mattkjames7 marked this pull request as ready for review December 4, 2025 12:27
@mattkjames7 mattkjames7 added this pull request to the merge queue Dec 4, 2025
Any commits made after this event will not be merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@imilinovic imilinovic imilinovic approved these changes

Assignees

@mattkjames7 mattkjames7

Labels

Docs needed Docs needed infrastructure

Projects

None yet

Milestone

mage-v3.8.0

Development

Successfully merging this pull request may close these issues.

3 participants

@mattkjames7 @imilinovic