fix(channel): return success when bind code is re-checked by same identity#201
Merged
sheepbox8646 merged 2 commits intomemohai:mainfrom Mar 7, 2026
Merged
fix(channel): return success when bind code is re-checked by same identity#201sheepbox8646 merged 2 commits intomemohai:mainfrom
sheepbox8646 merged 2 commits intomemohai:mainfrom
Conversation
sheepbox8646
approved these changes
Mar 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When binding a user identity via Telegram, the bot returns "Bind code already used" even though the binding process has succeeded in the database.
Root Cause
IdentityResolver.Resolve()is being called twice for each inbound message: by the middleware layer andHandleInbound. The second response overwrites the first, so the user only sees the error.Fix
Add a check in
tryHandleBindCode, When a bind code has already been used, check if it was used by the same channel identity. If yes, then return the success reply instead of an error.