Skip to content

fix(mcp): propagate network errors from replaceContainerSnapshot#204

Closed
HoneyBBQ wants to merge 1 commit intomainfrom
fix/versioning-network-fallback
Closed

fix(mcp): propagate network errors from replaceContainerSnapshot#204
HoneyBBQ wants to merge 1 commit intomainfrom
fix/versioning-network-fallback

Conversation

@HoneyBBQ
Copy link
Collaborator

@HoneyBBQ HoneyBBQ commented Mar 7, 2026

Summary

Changes

File Fix
internal/mcp/versioning.go Return error from SetupNetwork instead of logging a warning; also error when IP is empty

Test plan

  • Create a snapshot, rollback — verify container is reachable via gRPC after rollback
  • Simulate CNI failure during rollback — verify error is returned, not silently swallowed

Network setup failure after snapshot replace (rollback/commit) was
silently swallowed — the container would start but remain unreachable
via gRPC. Return the error so callers (CreateSnapshot, RollbackVersion,
etc.) surface the failure instead of reporting success.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants