Fix rendering regressions and stabilize loader runtime behavior#7
Open
KushagraSingh78 wants to merge 1 commit intomemory-hunter:masterfrom
Open
Fix rendering regressions and stabilize loader runtime behavior#7KushagraSingh78 wants to merge 1 commit intomemory-hunter:masterfrom
KushagraSingh78 wants to merge 1 commit intomemory-hunter:masterfrom
Conversation
KushagraSingh78
commented
Feb 27, 2026
KushagraSingh78
commented
- Restore per-frame nativeResize call to prevent text glitches/flicker
- Add required symbol validation before game init
- Keep loader logging disabled (no-op logger macros/backend)
- Quiet FalsoJNI logging in build config
- Fix unloadEffect path key mismatch in audio system
- Reduce redundant effect volume/rate updates
- Restore per-frame nativeResize call to prevent text glitches/flicker - Add required symbol validation before game init - Keep loader logging disabled (no-op logger macros/backend) - Quiet FalsoJNI logging in build config - Fix unloadEffect path key mismatch in audio system - Reduce redundant effect volume/rate updates
memory-hunter
requested changes
Mar 6, 2026
Owner
memory-hunter
left a comment
memory-hunter
left a comment
There was a problem hiding this comment.
I think this PR has literally nothing of substance apart from the CMakeLists part where you add the libraries because otherwise one gets linkage errors.
Owner
There was a problem hiding this comment.
Why are you even removing this?
Owner
There was a problem hiding this comment.
Why are you even removing this?
Owner
There was a problem hiding this comment.
I am not the owner so using ssh would be not correct. It can pull file using https.
Owner
There was a problem hiding this comment.
Please only leave in changes for adding the libraries which was required furhter for linkage errors. Don't add comments and don't remove the debug flags.
Owner
There was a problem hiding this comment.
What is this trying to achieve? Current impl is fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.