Simplified LOAD DATA LOCAL INFILE statement parsing#49
Merged
AdalbertMemSQL merged 3 commits intomasterfrom Nov 12, 2025
Merged
Simplified LOAD DATA LOCAL INFILE statement parsing#49AdalbertMemSQL merged 3 commits intomasterfrom
AdalbertMemSQL merged 3 commits intomasterfrom
Conversation
pmishchenko-ua
approved these changes
Nov 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The validateLocalFileName function checks that the filename requested by the server and provided in the query is the same. An old version of regexp tried to parse all versions of comments before LOAD DATA LOCAL INFILE. This caused stack overflow errors on big queries.
The new version just searches LOAD DATA... query somewhere inside the statement.