Skip to content

[function-grep] Added easier way to create languages using tree sitte… #283

[function-grep] Added easier way to create languages using tree sitte…

[function-grep] Added easier way to create languages using tree sitte… #283

GitHub Actions / clippy failed Sep 12, 2024 in 0s

clippy

6 errors, 9 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 6
Warning 9
Note 0
Help 0

Versions

  • rustc 1.81.0 (eeb90cda1 2024-09-04)
  • cargo 1.81.0 (2dbb1af80 2024-08-20)
  • clippy 0.1.81 (eeb90cd 2024-09-04)

Annotations

Check warning on line 85 in function-grep/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

first doc comment paragraph is too long

warning: first doc comment paragraph is too long
  --> function-grep/src/lib.rs:80:1
   |
80 | / /// Tries to find the appropiate language for the given file [`file_name`] based on the list of
81 | | /// languages [`langs`] provided.
82 | | /// This works by obtaining the extension from the file path and using
83 | | /// [`get_file_type_from_file_ext`].
84 | | ///
85 | | /// # Errors
   | |_
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_long_first_doc_paragraph

Check warning on line 263 in function-grep/src/supported_languages.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

first doc comment paragraph is too long

warning: first doc comment paragraph is too long
   --> function-grep/src/supported_languages.rs:257:1
    |
257 | / /// Use to more easily make new [`SupportedLanguage`]s.
258 | | /// First provide the name (which is used as the type of the language), followed by the tree sitter
259 | | /// languge in parenthesis, next you put the file extensions in brackets with a leading .
260 | | /// to specify the query we use ?= variable -> string literal query.
261 | | /// In the query you when you want use the variable just do {variable}.
262 | | ///
263 | | /// Example:
    | |_
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_long_first_doc_paragraph
    = note: `#[warn(clippy::too_long_first_doc_paragraph)]` on by default
help: add an empty line
    |
257 ~ /// Use to more easily make new [`SupportedLanguage`]s.
258 + ///
    |

Check warning on line 205 in function-grep/src/supported_languages.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

docs for function returning `Result` missing `# Errors` section

warning: docs for function returning `Result` missing `# Errors` section
   --> function-grep/src/supported_languages.rs:205:5
    |
205 |     fn instantiate_map(self, name: &'a str) -> Result<Vec<InstantiatedLanguage<'a>>, QueryError>;
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

Check failure on line 169 in function-grep/src/supported_languages.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

used `unwrap()` on a `Result` value

error: used `unwrap()` on a `Result` value
   --> function-grep/src/supported_languages.rs:167:24
    |
167 |               let tags = tag_config
    |  ________________________^
168 | |                 .generate_tags(&mut tag_context, code, None)
169 | |                 .unwrap()
    | |_________________________^
    |
    = note: if this value is an `Err`, it will panic
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used

Check failure on line 161 in function-grep/src/supported_languages.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

used `unwrap()` on a `Result` value

error: used `unwrap()` on a `Result` value
   --> function-grep/src/supported_languages.rs:161:13
    |
161 |             TagsConfiguration::new(self.language(), &self.tag_query().to_string(), "").unwrap(),
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: if this value is an `Err`, it will panic
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used

Check warning on line 137 in function-grep/src/supported_languages.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

some fields in `TagsConfigurationThreadSafe` are not safe to be sent to another thread

warning: some fields in `TagsConfigurationThreadSafe` are not safe to be sent to another thread
   --> function-grep/src/supported_languages.rs:137:1
    |
137 | unsafe impl Send for TagsConfigurationThreadSafe {}
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
note: it is not safe to send field `0` to another thread
   --> function-grep/src/supported_languages.rs:136:36
    |
136 | struct TagsConfigurationThreadSafe(TagsConfiguration);
    |                                    ^^^^^^^^^^^^^^^^^
    = help: use a thread-safe type that implements `Send`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_send_fields_in_send_ty
note: the lint level is defined here
   --> function-grep/src/lib.rs:5:27
    |
5   | #![warn(clippy::pedantic, clippy::nursery, clippy::cargo)]
    |                           ^^^^^^^^^^^^^^^
    = note: `#[warn(clippy::non_send_fields_in_send_ty)]` implied by `#[warn(clippy::nursery)]`

Check failure on line 126 in function-grep/src/supported_languages.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

used `unwrap()` on a `Result` value

error: used `unwrap()` on a `Result` value
   --> function-grep/src/supported_languages.rs:122:21
    |
122 |           let query = Query::new(
    |  _____________________^
123 | |             &self.language(),
124 | |             &self.query_string_function(search.as_ref()),
125 | |         )
126 | |         .unwrap();
    | |_________________^
    |
    = note: if this value is an `Err`, it will panic
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used

Check failure on line 112 in function-grep/src/supported_languages.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

used `unwrap()` on a `Result` value

error: used `unwrap()` on a `Result` value
   --> function-grep/src/supported_languages.rs:112:61
    |
112 |                         .any(|c| c.index == method_field && c.node.utf8_text(code).unwrap() == name)
    |                                                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: if this value is an `Err`, it will panic
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used

Check failure on line 103 in function-grep/src/supported_languages.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

used `unwrap()` on an `Option` value

error: used `unwrap()` on an `Option` value
   --> function-grep/src/supported_languages.rs:101:28
    |
101 |           let method_field = query
    |  ____________________________^
102 | |             .capture_index_for_name(&self.query_name().to_string())
103 | |             .unwrap();
    | |_____________________^
    |
    = note: if this value is `None`, it will panic
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used

Check failure on line 100 in function-grep/src/supported_languages.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

used `unwrap()` on a `Result` value

error: used `unwrap()` on a `Result` value
   --> function-grep/src/supported_languages.rs:100:21
    |
100 |         let query = Query::new(&self.language(), &self.query_string().to_string()).unwrap();
    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: if this value is an `Err`, it will panic
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used
note: the lint level is defined here
   --> function-grep/src/lib.rs:2:9
    |
2   | #![deny(clippy::unwrap_used, clippy::expect_used)]
    |         ^^^^^^^^^^^^^^^^^^^

Check warning on line 148 in function-grep/src/filter.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

manual `Debug` impl does not include all fields

warning: manual `Debug` impl does not include all fields
   --> function-grep/src/filter.rs:142:1
    |
142 | / impl std::fmt::Debug for InstantiatedFilter {
143 | |     fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
144 | |         f.debug_struct("InstantiatedFilter")
145 | |             .field("filter_information", &self.filter_information)
146 | |             .finish()
147 | |     }
148 | | }
    | |_^
    |
note: this field is unused
   --> function-grep/src/filter.rs:127:5
    |
127 |     filter_function: FilterFunction,
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    = help: consider including all fields in this `Debug` impl
    = help: consider calling `.finish_non_exhaustive()` if you intend to ignore fields
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_fields_in_debug
    = note: `#[warn(clippy::missing_fields_in_debug)]` implied by `#[warn(clippy::pedantic)]`

Check warning on line 125 in function-grep/src/filter.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

item name ends with its containing module's name

warning: item name ends with its containing module's name
   --> function-grep/src/filter.rs:125:12
    |
125 | pub struct InstantiatedFilter {
    |            ^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_name_repetitions

Check warning on line 49 in function-grep/src/filter.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

item name starts with its containing module's name

warning: item name starts with its containing module's name
  --> function-grep/src/filter.rs:49:12
   |
49 | pub struct FilterInformation {
   |            ^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_name_repetitions
   = note: `#[warn(clippy::module_name_repetitions)]` implied by `#[warn(clippy::pedantic)]`

Check warning on line 39 in function-grep/src/filter.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

docs for function returning `Result` missing `# Errors` section

warning: docs for function returning `Result` missing `# Errors` section
  --> function-grep/src/filter.rs:39:5
   |
39 |     fn to_filter(&self, s: &str) -> Result<InstantiatedFilter, String> {
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

Check warning on line 37 in function-grep/src/filter.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

docs for function returning `Result` missing `# Errors` section

warning: docs for function returning `Result` missing `# Errors` section
  --> function-grep/src/filter.rs:37:5
   |
37 |     fn parse_filter(&self, s: &str) -> Result<FilterFunction, String>;
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc
note: the lint level is defined here
  --> function-grep/src/lib.rs:5:9
   |
5  | #![warn(clippy::pedantic, clippy::nursery, clippy::cargo)]
   |         ^^^^^^^^^^^^^^^^
   = note: `#[warn(clippy::missing_errors_doc)]` implied by `#[warn(clippy::pedantic)]`