Skip to content

[function-grep] working on filter merging #293

[function-grep] working on filter merging

[function-grep] working on filter merging #293

GitHub Actions / clippy failed Nov 21, 2024 in 0s

clippy

6 errors, 14 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 6
Warning 14
Note 0
Help 0

Versions

  • rustc 1.82.0 (f6e511eec 2024-10-15)
  • cargo 1.82.0 (8f40fc59f 2024-08-21)
  • clippy 0.1.82 (f6e511e 2024-10-15)

Annotations

Check warning on line 85 in function-grep/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

first doc comment paragraph is too long

warning: first doc comment paragraph is too long
  --> function-grep/src/lib.rs:80:1
   |
80 | / /// Tries to find the appropiate language for the given file [`file_name`] based on the list of
81 | | /// languages [`langs`] provided.
82 | | /// This works by obtaining the extension from the file path and using
83 | | /// [`get_file_type_from_file_ext`].
84 | | ///
85 | | /// # Errors
   | |_^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_long_first_doc_paragraph

Check warning on line 263 in function-grep/src/supported_languages.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

first doc comment paragraph is too long

warning: first doc comment paragraph is too long
   --> function-grep/src/supported_languages.rs:257:1
    |
257 | / /// Use to more easily make new [`SupportedLanguage`]s.
258 | | /// First provide the name (which is used as the type of the language), followed by the tree sitter
259 | | /// languge in parenthesis, next you put the file extensions in brackets with a leading .
260 | | /// to specify the query we use ?= variable -> string literal query.
261 | | /// In the query you when you want use the variable just do {variable}.
262 | | ///
263 | | /// Example:
    | |_^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_long_first_doc_paragraph
    = note: `#[warn(clippy::too_long_first_doc_paragraph)]` implied by `#[warn(clippy::nursery)]`
help: add an empty line
    |
257 ~ /// Use to more easily make new [`SupportedLanguage`]s.
258 + ///
    |

Check warning on line 205 in function-grep/src/supported_languages.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

docs for function returning `Result` missing `# Errors` section

warning: docs for function returning `Result` missing `# Errors` section
   --> function-grep/src/supported_languages.rs:205:5
    |
205 |     fn instantiate_map(self, name: &'a str) -> Result<Vec<InstantiatedLanguage<'a>>, QueryError>;
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

Check failure on line 169 in function-grep/src/supported_languages.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

used `unwrap()` on a `Result` value

error: used `unwrap()` on a `Result` value
   --> function-grep/src/supported_languages.rs:167:24
    |
167 |               let tags = tag_config
    |  ________________________^
168 | |                 .generate_tags(&mut tag_context, code, None)
169 | |                 .unwrap()
    | |_________________________^
    |
    = note: if this value is an `Err`, it will panic
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used

Check failure on line 161 in function-grep/src/supported_languages.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

used `unwrap()` on a `Result` value

error: used `unwrap()` on a `Result` value
   --> function-grep/src/supported_languages.rs:161:13
    |
161 |             TagsConfiguration::new(self.language(), &self.tag_query().to_string(), "").unwrap(),
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: if this value is an `Err`, it will panic
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used

Check warning on line 137 in function-grep/src/supported_languages.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

some fields in `TagsConfigurationThreadSafe` are not safe to be sent to another thread

warning: some fields in `TagsConfigurationThreadSafe` are not safe to be sent to another thread
   --> function-grep/src/supported_languages.rs:137:1
    |
137 | unsafe impl Send for TagsConfigurationThreadSafe {}
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
note: it is not safe to send field `0` to another thread
   --> function-grep/src/supported_languages.rs:136:36
    |
136 | struct TagsConfigurationThreadSafe(TagsConfiguration);
    |                                    ^^^^^^^^^^^^^^^^^
    = help: use a thread-safe type that implements `Send`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_send_fields_in_send_ty
note: the lint level is defined here
   --> function-grep/src/lib.rs:5:27
    |
5   | #![warn(clippy::pedantic, clippy::nursery, clippy::cargo)]
    |                           ^^^^^^^^^^^^^^^
    = note: `#[warn(clippy::non_send_fields_in_send_ty)]` implied by `#[warn(clippy::nursery)]`

Check failure on line 126 in function-grep/src/supported_languages.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

used `unwrap()` on a `Result` value

error: used `unwrap()` on a `Result` value
   --> function-grep/src/supported_languages.rs:122:21
    |
122 |           let query = Query::new(
    |  _____________________^
123 | |             &self.language(),
124 | |             &self.query_string_function(search.as_ref()),
125 | |         )
126 | |         .unwrap();
    | |_________________^
    |
    = note: if this value is an `Err`, it will panic
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used

Check failure on line 112 in function-grep/src/supported_languages.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

used `unwrap()` on a `Result` value

error: used `unwrap()` on a `Result` value
   --> function-grep/src/supported_languages.rs:112:61
    |
112 |                         .any(|c| c.index == method_field && c.node.utf8_text(code).unwrap() == name)
    |                                                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: if this value is an `Err`, it will panic
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used

Check failure on line 103 in function-grep/src/supported_languages.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

used `unwrap()` on an `Option` value

error: used `unwrap()` on an `Option` value
   --> function-grep/src/supported_languages.rs:101:28
    |
101 |           let method_field = query
    |  ____________________________^
102 | |             .capture_index_for_name(&self.query_name().to_string())
103 | |             .unwrap();
    | |_____________________^
    |
    = note: if this value is `None`, it will panic
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used

Check failure on line 100 in function-grep/src/supported_languages.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

used `unwrap()` on a `Result` value

error: used `unwrap()` on a `Result` value
   --> function-grep/src/supported_languages.rs:100:21
    |
100 |         let query = Query::new(&self.language(), &self.query_string().to_string()).unwrap();
    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: if this value is an `Err`, it will panic
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used
note: the lint level is defined here
   --> function-grep/src/lib.rs:2:9
    |
2   | #![deny(clippy::unwrap_used, clippy::expect_used)]
    |         ^^^^^^^^^^^^^^^^^^^

Check warning on line 360 in function-grep/src/filter.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

docs for function returning `Result` missing `# Errors` section

warning: docs for function returning `Result` missing `# Errors` section
   --> function-grep/src/filter.rs:360:5
    |
360 |     pub fn add_filter(&mut self, filter: impl Into<FilterType<'a>>) -> Result<(), String> {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

Check warning on line 356 in function-grep/src/filter.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

method `default` can be confused for the standard trait method `std::default::Default::default`

warning: method `default` can be confused for the standard trait method `std::default::Default::default`
   --> function-grep/src/filter.rs:324:5
    |
324 | /     pub fn default() -> Self {
325 | |         Self {
326 | |             filters: HashMap::from([
327 | |                 (
...   |
355 | |         }
356 | |     }
    | |_____^
    |
    = help: consider implementing the trait `std::default::Default` or choosing a less ambiguous method name
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
    = note: `#[warn(clippy::should_implement_trait)]` on by default

Check warning on line 272 in function-grep/src/filter.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

docs for function returning `Result` missing `# Errors` section

warning: docs for function returning `Result` missing `# Errors` section
   --> function-grep/src/filter.rs:272:5
    |
272 |     pub fn to_filter(&self, s: &str) -> Result<InstantiatedFilterType, String> {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

Check warning on line 263 in function-grep/src/filter.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'a

warning: the following explicit lifetimes could be elided: 'a
   --> function-grep/src/filter.rs:263:6
    |
263 | impl<'a> FilterType<'a> {
    |      ^^             ^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
    = note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
    |
263 - impl<'a> FilterType<'a> {
263 + impl FilterType<'_> {
    |

Check warning on line 160 in function-grep/src/filter.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

manual `Debug` impl does not include all fields

warning: manual `Debug` impl does not include all fields
   --> function-grep/src/filter.rs:154:1
    |
154 | / impl<Supports: std::fmt::Debug> std::fmt::Debug for InstantiatedFilter<Supports> {
155 | |     fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
156 | |         f.debug_struct("InstantiatedFilter")
157 | |             .field("filter_information", &self.filter_information)
158 | |             .finish()
159 | |     }
160 | | }
    | |_^
    |
note: this field is unused
   --> function-grep/src/filter.rs:135:5
    |
135 |     filter_function: FilterFunction,
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    = help: consider including all fields in this `Debug` impl
    = help: consider calling `.finish_non_exhaustive()` if you intend to ignore fields
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_fields_in_debug
    = note: `#[warn(clippy::missing_fields_in_debug)]` implied by `#[warn(clippy::pedantic)]`

Check warning on line 145 in function-grep/src/filter.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

re-implementing `PartialEq::ne` is unnecessary

warning: re-implementing `PartialEq::ne` is unnecessary
   --> function-grep/src/filter.rs:143:5
    |
143 | /     fn ne(&self, other: &Self) -> bool {
144 | |         !self.eq(other)
145 | |     }
    | |_____^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl
    = note: `#[warn(clippy::partialeq_ne_impl)]` on by default

Check warning on line 44 in function-grep/src/filter.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

docs for function returning `Result` missing `# Errors` section

warning: docs for function returning `Result` missing `# Errors` section
  --> function-grep/src/filter.rs:44:5
   |
44 |     fn to_filter(&self, s: &str) -> Result<InstantiatedFilter<Self::Supports>, String> {
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

Check warning on line 42 in function-grep/src/filter.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

docs for function returning `Result` missing `# Errors` section

warning: docs for function returning `Result` missing `# Errors` section
  --> function-grep/src/filter.rs:42:5
   |
42 |     fn parse_filter(&self, s: &str) -> Result<FilterFunction, String>;
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc
note: the lint level is defined here
  --> function-grep/src/lib.rs:5:9
   |
5  | #![warn(clippy::pedantic, clippy::nursery, clippy::cargo)]
   |         ^^^^^^^^^^^^^^^^
   = note: `#[warn(clippy::missing_errors_doc)]` implied by `#[warn(clippy::pedantic)]`

Check warning on line 138 in function-grep/src/filter/general_filters.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `s`

warning: unused variable: `s`
   --> function-grep/src/filter/general_filters.rs:138:28
    |
138 |     fn parse_filter(&self, s: &str) -> Result<FilterFunction, String> {
    |                            ^ help: if this is intentional, prefix it with an underscore: `_s`
    |
    = note: `#[warn(unused_variables)]` on by default

Check warning on line 210 in function-grep/src/filter.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused macro definition: `default_filters`

warning: unused macro definition: `default_filters`
   --> function-grep/src/filter.rs:210:14
    |
210 | macro_rules! default_filters {
    |              ^^^^^^^^^^^^^^^
    |
    = note: `#[warn(unused_macros)]` on by default