-
Notifications
You must be signed in to change notification settings - Fork 147
Fix: PATs are not restricted in SSO user accounts anymore #2715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fix: PATs are not restricted in SSO user accounts anymore #2715
Conversation
nickanderson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I think that we should call out the fact that if you are using external authentication like SAML SSO (i guess oauth as well or oidc) that disabling the user at the IDP is not sufficient to disable their personal access tokens. It must be done explicitly for the user (thought it will be revoked/invalidated) on specific account actions (plan level change, add-on add/removal). I wish we had an exhaustive list of what actions cause the PAT invalidation.
|
@nickanderson I agree. But I don't think it necesarily should be part of this PR. What do you think? |
nickanderson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do think we should call it out. To me it makes sense that it's in the same PR, it looks like there is a PAT section just above that is maybe a reasonable place to add a warning.
@olehermanse Opinion?
For context check on MEN-6725 Changelog: None Ticket: None Signed-off-by: Luis Ramirez <luis.ramirez@northern.tech>
5011d34 to
b469617
Compare
…t revoke PATs Ticket: None Changelo: None Signed-off-by: Luis Ramirez <luis.ramirez@northern.tech>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to.me
For context check on MEN-6725
Changelog: None
Ticket: None
External Contributor Checklist
🚨 Please review the guidelines for contributing to this repository.
The majority of our contributions are fixes, which means your commit should have
the form below:
git --signoff. Also note that the signoff author must match the author of the commit.Description
Please describe your pull request.
Thank you!