add: support for multiple ICS and Google calendars.#115
Open
KaeroDot wants to merge 1 commit intomendhak:masterfrom
Open
add: support for multiple ICS and Google calendars.#115KaeroDot wants to merge 1 commit intomendhak:masterfrom
KaeroDot wants to merge 1 commit intomendhak:masterfrom
Conversation
urlib3 version requirements had to be fixed. Also removed deprecated .utcnow()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have added support for up to 5 google calendars and up to 5 ics calendars. All available calendars are fetched, events sorted and displayed together according the event start date. Personally I need to show up events from 2 google calendars and one ics calendar. I use my own layout with more calendar space (I will share this later).
Unfortunately I haven't got outlook or caldav calendars to test them also.
I had to modify time zone operations so the events from all calendars can be joined into one compatible array and properly sorted. Hopefully I have chosen proper approach.
Additionally, urlib3 version requirements had to be loosened otherwise I got compatibility issues:
The user requested urllib3==2.5.0
icalevents 0.3.0 depends on urllib3>=1.26.5
requests 2.28.1 depends on urllib3<1.27 and >=1.21.1
I have removed deprecated .utcnow().