Skip to content

fix: add another view to avoid touching events #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stelselim wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: add another view to avoid touching events #405

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ba4de33
fix: add another view to avoid touching events
stelselim Jan 14, 2026
796c477
chore: update version number, and add changelog
stelselim Jan 14, 2026
a478c4b
chore: update snapshots
stelselim Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/pluggableWidgets/popup-menu-native/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),

## [Unreleased]

- We fixed an iOS issue where native Popup Menu icons were not tappable and failed to open the menu.

## [4.0.0] - 2024-12-3

### Changed
Expand Down
2 changes: 1 addition & 1 deletion packages/pluggableWidgets/popup-menu-native/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "popup-menu-native",
"widgetName": "PopupMenu",
"version": "4.0.0",
"version": "4.0.1",
"license": "Apache-2.0",
"repository": {
"type": "git",
Expand Down
4 changes: 2 additions & 2 deletions packages/pluggableWidgets/popup-menu-native/src/PopupMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
const menuRef = useRef<Menu | null>(null);
const showMenu = useCallback(() => {
menuRef.current?.show();
}, [menuRef.current]);

Check warning on line 30 in packages/pluggableWidgets/popup-menu-native/src/PopupMenu.tsx

View workflow job for this annotation

GitHub Actions / Unit tests 

React Hook useCallback has an unnecessary dependency: 'menuRef.current'. Either exclude it or remove the dependency array. Mutable values like 'menuRef.current' aren't valid dependencies because mutating them doesn't re-render the component
const handlePress = useCallback(
(action?: ActionValue) => {
menuRef.current?.hide();
Expand All @@ -36,7 +36,7 @@
executeAction(action);
}, 500);
},
[menuRef.current]

Check warning on line 39 in packages/pluggableWidgets/popup-menu-native/src/PopupMenu.tsx

View workflow job for this annotation

GitHub Actions / Unit tests 

React Hook useCallback has an unnecessary dependency: 'menuRef.current'. Either exclude it or remove the dependency array. Mutable values like 'menuRef.current' aren't valid dependencies because mutating them doesn't re-render the component
);

let menuOptions: ReactElement[];
Expand Down Expand Up @@ -84,8 +84,8 @@
style={styles?.container as any}
button={
<TouchableButton onPress={showMenu} testID={`${props.name}_trigger`}>
<View pointerEvents="box-only" style={styles.buttonContainer}>
{props.menuTriggerer}
<View style={styles.buttonContainer} pointerEvents="box-only">
<View pointerEvents="none">{props.menuTriggerer}</View>
</View>
</TouchableButton>
}
Expand All @@ -100,7 +100,7 @@
);
}

function getRippleColor(color: string | undefined) {

Check warning on line 103 in packages/pluggableWidgets/popup-menu-native/src/PopupMenu.tsx

View workflow job for this annotation

GitHub Actions / Unit tests 

Missing return type on function
if (color) {
return Platform.OS === "android"
? color && { background: TouchableNativeFeedback.Ripple(color, false) }
Expand Down
20 changes: 14 additions & 6 deletions ...es/pluggableWidgets/popup-menu-native/src/__tests__/__snapshots__/PopupMenu.spec.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,13 @@ exports[`Popup menu renders 1`] = `
pointerEvents="box-only"
testID="popup-menu_trigger"
>
<Text>
Menu Triggerer
</Text>
<View
pointerEvents="none"
>
<Text>
Menu Triggerer
</Text>
</View>
</View>
</View>
<View
Expand Down Expand Up @@ -242,9 +246,13 @@ exports[`Popup menu renders custom items 1`] = `
pointerEvents="box-only"
testID="popup-menu_trigger"
>
<Text>
Menu Triggerer
</Text>
<View
pointerEvents="none"
>
<Text>
Menu Triggerer
</Text>
</View>
</View>
</View>
<View
Expand Down
2 changes: 1 addition & 1 deletion packages/pluggableWidgets/popup-menu-native/src/package.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="utf-8" ?>
<package xmlns="http://www.mendix.com/package/1.0/">
<clientModule name="PopupMenu" version="4.0.0" xmlns="http://www.mendix.com/clientModule/1.0/">
<clientModule name="PopupMenu" version="4.0.1" xmlns="http://www.mendix.com/clientModule/1.0/">
<widgetFiles>
<widgetFile path="PopupMenu.xml" />
</widgetFiles>
Expand Down
Loading