Skip to content

Conversation

@weirdwater
Copy link
Collaborator

@weirdwater weirdwater commented Nov 22, 2024

Checklist

  • Contains unit tests ✅ ❌
  • Contains breaking changes ✅
  • Compatible with: MX 🔟
  • Did you update version and changelog? ✅
  • PR title properly formatted ([XX-000]: description)? ✅

This PR contains

  • Bug fix
  • Feature
  • Refactor
  • Documentation
  • Other (describe)

What is the purpose of this PR?

This PR aims to upgrade the bundler setup in order to offer more recent packages and extend the longevity of the package.

Relevant changes

Package versions have been updated and modifications have been made to the Rollup and jest configurations to be compatible with newer versions.

What should be covered while testing?

How to test the branch locally:

  1. Pull repository and checkout this branch wtf/rollup-3
  2. Run npm pack
  3. Copy the full path of the resulting archive (The previous command states the name of the file)
  4. In the widget directory, run npm install $full_path_to_archive

Properties to check:

  • Newly generated widgets should build and test without any modification necessary.
  • Widgets without custom configuration should build and test without any modification necessary.
  • Widgets with custom configuration (for example carousel-web) should be upgrade-able using the guide in CHANGELOG.md

Extra comments (optional)

@weirdwater weirdwater requested a review from a team as a code owner November 22, 2024 15:43
@weirdwater weirdwater force-pushed the wtf/rollup-3 branch 4 times, most recently from 8a4230e to af361ff Compare November 25, 2024 10:30
@alihcsumer alihcsumer merged commit 8685d2c into master Dec 10, 2024
7 checks passed
@alihcsumer alihcsumer deleted the wtf/rollup-3 branch December 10, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants