[WC-2862]: fix import and bump ts-node #117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weirdwater
requested changes
Mar 10, 2025
Collaborator
weirdwater
left a comment
weirdwater
left a comment
There was a problem hiding this comment.
Thanks for the fix. To push the update through we will need the version to be applied to the lockfile as well, see the relevant comment how to do so.
Collaborator
|
@r0b1n, we merged the fixes to the CI/CD to master. You can rebase your branch to pass the CI/CD checks. |
weirdwater
approved these changes
Mar 11, 2025
alihcsumer
approved these changes
Mar 11, 2025
weirdwater
added a commit
that referenced
this pull request
Mar 21, 2025
PR #117 addressed an import of a common js module that assumed it had a named export, which caused an error in some environments. It appears that this fix broke other widgets with custom configuration as the imported module does not have a default exported member. This PR addresses both issues. It has been verified with the widgets that broke before and after 10.18.1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
This PR contains
What is the purpose of this PR?
Potentially fix some interesting build errors.
Update ts-node.