Skip to content

Conversation

@LEGIO-SEXTA-FERRATA
Copy link
Contributor

@LEGIO-SEXTA-FERRATA LEGIO-SEXTA-FERRATA commented Nov 28, 2025

Checklist

  • Contains unit tests ✅
  • Contains breaking changes ✅
  • Compatible with: MX 1️⃣1️⃣
  • Did you update version and changelog? ❌
  • PR title properly formatted ([XX-000]: description)? ✅

This PR contains

  • Bug fix
  • Feature
  • Refactor
  • Documentation
  • Other (describe)

What is the purpose of this PR?

This PR prepares the Yeoman widget generator for replacing the Enzyme for testing in favor of RTL, the React Testing Library.

Relevant changes

  • The generator for web package.json is adjusted to remove enzyme as a dependency
  • The react-dom dependency is added to resolutions and overrides as RTL required it
  • The scaffolded unit tests when the user chooses the unit test option are adjusted for RTL
  • Generator tests are adjusted
  • A bonus fix for updating the copyright year is included.

What should be covered while testing?

  • Both the options with unit test and e2e should be tested
  • The generator tests must be green
  • The default tests that arrive with a scaffolded widget should be green

REMAINING:

  • Check native
  • Check e2e tests
  • PWT Workflow Actions seems to be failing for the PR
  • One issue is that, the scaffolded widget is not able to run the unit tests before npm install is run
  • Check if we can get rid of the non-enzyme config in PWT
  • Add a check in PWT to detect and warn on enzyme tests (grepping on enzyme imports will do probably)
  • Mention as breaking change in release notes
  • Check docs

@alihcsumer alihcsumer force-pushed the WTF-2273-remove-enzyme branch 3 times, most recently from eaab3ca to e413267 Compare December 3, 2025 22:11
@alihcsumer alihcsumer force-pushed the WTF-2273-remove-enzyme branch 2 times, most recently from ba40f08 to 5c6c594 Compare December 4, 2025 14:45
@alihcsumer alihcsumer force-pushed the WTF-2273-remove-enzyme branch from 3dc1e92 to 6ef55e0 Compare December 10, 2025 14:58
@weirdwater weirdwater force-pushed the WTF-2273-remove-enzyme branch from 913d341 to 053aef8 Compare January 12, 2026 15:48
Copy link
Collaborator

@mlaponder mlaponder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mlaponder mlaponder force-pushed the WTF-2273-remove-enzyme branch from 053aef8 to bc9fe30 Compare January 14, 2026 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants