[WTF-2485]: Remove enzyme from widget generator in preparation of React 19 #156
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,8 +21,8 @@ | |
| "build": "pluggable-widgets-tools build:web", | ||
| "lint": "pluggable-widgets-tools lint", | ||
| "lint:fix": "pluggable-widgets-tools lint:fix", | ||
| "test": "pluggable-widgets-tools test:unit:web && npm run test:e2e", | ||
| "test:unit": "pluggable-widgets-tools test:unit:web", | ||
|
Collaborator
There was a problem hiding this comment. When running unit tests on a generated widget from the command line I get the following error:
Collaborator
There was a problem hiding this comment. Was the widget using the correct packages? The testing procedure I used resulted in the tests passing without errors: # Prepare artifacts
cd $PATH_TO_REPO
pnpm install
pnpm --dir packages/pluggable-widgets-tools pack
cd ~/Mendix/TestApp/myPluggableWidgets
$PATH_TO_REPO/packages/generator-widget/bin.js fullBPWidget
# Choose full boilerplate and say yes to tests
cd fullPBWidget
npm install $PATH_TO_REPO/packages/pluggable-widgets-tools/mendix-pluggable-widgets-tools-11.3.0.tgz
npm test
Collaborator
There was a problem hiding this comment. @weirdwater I did not use the pluggable widget tools from this branch. The tools version mentioned in the package json on a fresh generated widget mentioned ^10.15.0 so I was expecting it to work with that version.
Collaborator
There was a problem hiding this comment. That would explain the discrepancy between the different testing experiences. As you say, if the updated tools are needed, we should update the minimum version in the generator. In this case the changes in both packages cannot be seen separate from each other. So the minimum version in the package template should be updated to
Contributor
Author
There was a problem hiding this comment. The dependency version should indeed be raised, as this is also a breaking change anyways. But still, this is a concern for after the package is published. The error I'm getting (which is different than the one Marco shared) after making sure the widget targets |
||
| "test:e2e": "npx cypress open --browser chrome --e2e", | ||
| "prerelease": "npm run lint", | ||
| "release": "pluggable-widgets-tools release:web" | ||
|
|
@@ -36,10 +36,12 @@ | |
| }, | ||
| "resolutions": { | ||
| "react": "^18.2.0", | ||
| "react-dom": "18.2.0", | ||
| "react-native": "0.72.7" | ||
| }, | ||
| "overrides": { | ||
| "react": "^18.2.0", | ||
| "react-dom": "18.2.0", | ||
| "react-native": "0.72.7" | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,21 +1,19 @@ | ||
| import { createElement } from "react"; | ||
| import { render } from "@testing-library/react"; | ||
| import "@testing-library/jest-dom"; | ||
|
|
||
| import { HelloWorldSample } from "../HelloWorldSample"; | ||
|
|
||
| describe("HelloWorldSample", () => { | ||
| it("should render the structure correctly", () => { | ||
| const helloWorldProps = { | ||
| sampleText: "World" | ||
| }; | ||
|
|
||
| const { container } = render(<HelloWorldSample {...helloWorldProps} />); | ||
|
|
||
| const helloWorld = container.querySelector(".widget-hello-world"); | ||
| expect(helloWorld).toBeInTheDocument(); | ||
| expect(helloWorld).toHaveTextContent(`Hello ${helloWorldProps.sampleText}`); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,21 +1,19 @@ | ||
| import { createElement } from "react"; | ||
| import { render } from "@testing-library/react"; | ||
| import "@testing-library/jest-dom"; | ||
|
|
||
| import { HelloWorldSample } from "../HelloWorldSample"; | ||
|
|
||
| describe("HelloWorldSample", () => { | ||
| it("should render the structure correctly", () => { | ||
| const helloWorldProps = { | ||
| sampleText: "World" | ||
| }; | ||
|
|
||
| const { container } = render(<HelloWorldSample {...helloWorldProps} />); | ||
|
|
||
| const helloWorld = container.querySelector(".widget-hello-world"); | ||
| expect(helloWorld).toBeInTheDocument(); | ||
| expect(helloWorld).toHaveTextContent(`Hello ${helloWorldProps.sampleText}`); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,22 +1,19 @@ | ||
| import { createElement } from "react"; | ||
| import { render } from "@testing-library/react"; | ||
| import "@testing-library/jest-dom"; | ||
|
|
||
| import { HelloWorldSample, HelloWorldSampleProps } from "../HelloWorldSample"; | ||
|
|
||
| describe("HelloWorldSample", () => { | ||
| it("should render the structure correctly", () => { | ||
| const helloWorldProps: HelloWorldSampleProps = { | ||
| sampleText: "World" | ||
| }; | ||
|
|
||
| const { container } = render(<HelloWorldSample {...helloWorldProps} />); | ||
|
|
||
| const helloWorld = container.querySelector(".widget-hello-world"); | ||
| expect(helloWorld).toBeInTheDocument(); | ||
| expect(helloWorld).toHaveTextContent(`Hello ${helloWorldProps.sampleText}`); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,22 +1,19 @@ | ||
| import { createElement } from "react"; | ||
| import { render } from "@testing-library/react"; | ||
| import "@testing-library/jest-dom"; | ||
|
|
||
| import { HelloWorldSample, HelloWorldSampleProps } from "../HelloWorldSample"; | ||
|
|
||
| describe("HelloWorldSample", () => { | ||
| it("should render the structure correctly", () => { | ||
| const helloWorldProps: HelloWorldSampleProps = { | ||
| sampleText: "World" | ||
| }; | ||
|
|
||
| const { container } = render(<HelloWorldSample {...helloWorldProps} />); | ||
|
|
||
| const helloWorld = container.querySelector(".widget-hello-world"); | ||
| expect(helloWorld).toBeInTheDocument(); | ||
| expect(helloWorld).toHaveTextContent(`Hello ${helloWorldProps.sampleText}`); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.