[WTF-2452] Fix transformation for require of external library with as output format #157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
[XX-000]: description)? ✅This PR contains
What is the purpose of this PR?
Fix transformation by the commonjs plugin in case the output format is es and an external library is required.
Relevant changes
For React client
requirestatements to external libraries need to be rewritten to animportstatement. However as the externally libraries were marked asignorein the commonjs plugin configuration those require statements were left untouched, causing the runtime error "require is not defined".This has been resolved by no longer marking external libraries as
ignored.What should be covered while testing?
Building widget which needs this transformation can be bundled and run without a custom rollup config. Examples are:
calendar-web
color-picker-web
document-viewer-web