Open
Conversation
added 7 commits
January 17, 2026 22:30
Owner
|
I'll take a look. Thank you! |
Owner
|
Sorry been a bit busy. I'll try and get to it before end of the week. |
Author
|
All good. One bug I found was that navigating from the sort/filter buttons to the assets does not work if there are only 1-2 assets that exist after filtering. Just something to keep in mind. Thanks! |
Owner
|
OK, I'm going split this into smaller PRs. Starting with sorting and filtering by time buckets and cities first. They have almost no performance bottleneck. I have to do a bit of thinking about how we can improve performance of the other filters, or load them only when the user explicitly requests. Hope that makes sense! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added sorting and filtering options to the all photos tab. Mostly vibe coded (not familiar with Swift), definitely needs some optimization when fetching all devices and when fetching the filtered assets (Takes about 10 seconds to load filtered assets for my ~13k asset instance). Also added a timezone setting for displaying datetimes in local time. Not ready to be merged but could be a good start for full implementation.