feat: v3 liquidity management#118
Merged
bayological merged 18 commits intofeat/sdk-v3from Feb 25, 2026
Merged
Conversation
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
simeon-clawd
suggested changes
Jan 30, 2026
Contributor
simeon-clawd
left a comment
simeon-clawd
left a comment
There was a problem hiding this comment.
🔒 Security, Accuracy & Correctness Review
The core add/remove liquidity paths are solid and well-tested. Main concerns are in zap operations — see inline comments.
| Severity | Count |
|---|---|
| 🔴 Critical | 3 |
| 🟡 Medium | 4 |
| 🟢 Minor | 4 |
✅ What's Done Well
- Clean module separation (helpers, basic liquidity, zap in, zap out)
- Thorough test coverage: unit, edge cases, output verification, integration
- Proper validation: address checks, pool type enforcement, token matching, slippage bounds
- Correct ABI signatures matching the Router contract
- Token order flexibility delegating to Router
- Clean approval handling pattern
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Upade to allow liquidity provisioning via the SDK including zaps
Tested