test: enforce 60% Jest coverage thresholds in CI#133
Merged
bayological merged 1 commit intomainfrom Mar 11, 2026
Merged
Conversation
Add coverageThreshold to jest.config.ts to fail CI when coverage drops below 60% for statements, functions, and branches. collectCoverage is already enabled globally, so thresholds are enforced on every test run including CI (pnpm test:unit). Addresses finding H-2 from mento-sdk QA audit (MEN-14).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
coverageThresholdtojest.config.tsso CI fails when coverage drops below acceptable levels.Problem
No coverage thresholds were enforced — CI would pass even if coverage regressed to 0%. This was identified as finding H-2 in the mento-sdk QA audit ([MEN-14]).
Specifically:
Changes
coverageThresholdinjest.config.tswith 60% minimum for statements, functions, and branchescollectCoverage: trueis already configured globally, so thresholds are enforced on everyjestrun including CI (pnpm test:unit)Coverage Thresholds Set
Rationale
60% is a pragmatic starting baseline — not perfect coverage, but enough to catch regressions in critical paths. The intent is to incrementally raise these thresholds as coverage improves.
Related