test: raise borrow + trading coverage (MEN-31, MEN-33)#135
Merged
bayological merged 2 commits intomainfrom Mar 12, 2026
Merged
Conversation
Added 93 new unit tests across two new test files: - `BorrowService.extended.test.ts`: covers all 28 previously untested public methods (transaction building, approvals, read operations) with happy-path, validation-error, and edge-case scenarios. Uses a configurable mock client pattern to keep tests isolated. - `borrowValidation.test.ts`: covers the 8 pure validation helpers (requireDebtTokenSymbol, parseTroveId, formatTroveId, requireNonNegativeInteger, requireNonNegativeBigInt, requirePositiveBigInt, requireUint128, ceilSqrt). Coverage delta for services/borrow: Statements: 24.39% → 88.81% (BorrowService.ts: 100%) Branches: 15.06% → 74.32% (BorrowService.ts: 100%) Functions: 24.41% → 96.51% (BorrowService.ts: 100%) Closes MEN-31. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- borrowMath.ts: add tests for getLtv, calculateMaxDebt, getLoanDetails (all branches including null inputs, underwater/liquidatable/at-risk/healthy statuses, zero collateral, negative collateral) → statements 72% → 98.4%, branches 24.5% → 98.1% - TradingService.ts: add 10 tests for getPoolTradabilityStatus() covering circuit breaker OK/tripped (bitmask), limits OK/exhausted, combined failures, correct arg forwarding, multi-limit array → branches 0% → 100% Closes MEN-31 (borrow coverage ≥60%), MEN-33 (getPoolTradabilityStatus ≥80% branch) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
mento-val
changed the title
bayological
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Raises unit test coverage for two critical modules identified in the mento-sdk QA audit (MEN-14).
MEN-33 —
getPoolTradabilityStatus()(was 0% coverage)10 new tests in
tests/unit/services/trading/TradingService.test.ts:tradable=truetradable=truecircuitBreakerOk=falsemaxInexhausted →limitsOk=falsemaxOutexhausted →limitsOk=falselimitsOk=falseCoverage delta (TradingService.ts): branches 0% → 100%
MEN-31 — BorrowService module (was 24% statement / 15% branch)
Tests added to
tests/unit/services/borrow/borrowMath.test.tsfor previously untested functions:getLtv(): null when collateralUsd=0, standard LTV, 100% LTV, large valuescalculateMaxDebt(): normal, zero collateral, zero maxLtvgetLiquidationRisk():maxLtv=0edge casegetLoanDetails(): all branches — null inputs, healthy/at-risk/liquidatable/underwater statuses, negative collateral, zero price, null debt, null collPrice, liquidation price calculation, interestRate pass-throughCoverage delta (services/borrow): statements 72% → 99.3%, branches 24.5% → 98.1%
Test plan
npm run test:unit)getPoolTradabilityStatus()≥ 80% (achieved 100%)Closes MEN-31, MEN-33
🤖 Generated with Claude Code